Commit 43e4564
committed
refactor: simplify to honest benchmarking without fragile assumptions
HONEST ASSESSMENT:
- Cannot validate grep regex for PHPBench 1.6 JSON without testing
- Shell float comparison is fragile and error-prone
- Better to run benchmark and review output than guess thresholds
WHAT THIS DOES:
- Runs PHPBench in CI mode: 10 revisions × 20 iterations, warmup=2
- Outputs: console (for logs) + JSON (for artifact)
- No automatic threshold enforcement (maintainer to review)
WHAT THIS DOESN'T DO:
- No fragile grep/bc threshold checking
- No assumed JSON structure parsing
- No automatic quality gate (honest about limitations)
WHAT SHOULD HAPPEN NEXT:
1. Run this PR to see actual benchmark output format
2. Maintainer sets realistic thresholds based on actual numbers
3. Add proper threshold validation once structure is known
Better to be honest about unknowns than deploy broken automation.
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>1 parent 3e0e7e8 commit 43e4564
1 file changed
Lines changed: 16 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
36 | | - | |
| 37 | + | |
37 | 38 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
48 | 44 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
54 | 49 | | |
55 | | - | |
| 50 | + | |
56 | 51 | | |
57 | 52 | | |
58 | 53 | | |
| |||
0 commit comments