refactor: remove mvp wording from unsupported subset messaging

vitormattos · vitormattos · commit 66de3dff9947 · 2026-05-27T18:31:16.000-03:00
Signed-off-by: Vitor Mattos &lt;1079143+vitormattos@users.noreply.github.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,4 +9,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Added
 
-- Initial bootstrap for MVP HTML+CSS subset to Form XObject compilation.
+- Initial bootstrap for HTML+CSS subset to Form XObject compilation.
diff --git a/src/Html/SubsetHtmlParser.php b/src/Html/SubsetHtmlParser.php
@@ -26,7 +26,13 @@ final class SubsetHtmlParser
     public function parse(string $html): array
     {
         $dom = new DOMDocument('1.0', 'UTF-8');
-        @$dom->loadHTML('<?xml encoding="utf-8" ?><body>' . $html . '</body>', LIBXML_NOERROR | LIBXML_NOWARNING);
+        $previousUseInternalErrors = libxml_use_internal_errors(true);
+        $dom->loadHTML(
+            '<?xml encoding="utf-8" ?><body>' . $html . '</body>',
+            LIBXML_NOERROR | LIBXML_NOWARNING,
+        );
+        libxml_clear_errors();
+        libxml_use_internal_errors($previousUseInternalErrors);
 
         $body = $dom->getElementsByTagName('body')->item(0);
         if (!$body instanceof DOMElement) {
@@ -49,12 +55,14 @@ private function parseDomNode(DOMNode $node, string $inheritedStyle): ?Node
         if ($node instanceof DOMElement) {
             $tag = strtolower($node->tagName);
             if (!isset($this->allowedTags[$tag])) {
-                throw new UnsupportedSubsetException(sprintf('Tag <%s> is not supported in MVP subset.', $tag));
+                throw new UnsupportedSubsetException(sprintf('Tag <%s> is not supported.', $tag));
             }
 
             $attributes = [];
-            foreach ($node->attributes as $attribute) {
-                $attributes[strtolower($attribute->name)] = $attribute->value;
+            if ($node->attributes !== null) {
+                foreach ($node->attributes as $attribute) {
+                    $attributes[strtolower($attribute->name)] = $attribute->value;
+                }
             }
 
             $ownStyle = $attributes['style'] ?? '';
@@ -79,7 +87,7 @@ private function parseDomNode(DOMNode $node, string $inheritedStyle): ?Node
             );
         }
 
-        $text = trim($node->textContent ?? '');
+        $text = trim($node->textContent);
         if ($text === '') {
             return null;
         }

Original file line number	Diff line number	Diff line change
`@@ -9,4 +9,4 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0`
`9`	`9`
`10`	`10`	`### Added`
`11`	`11`
`12`		`-- Initial bootstrap for MVP HTML+CSS subset to Form XObject compilation.`
	`12`	`+- Initial bootstrap for HTML+CSS subset to Form XObject compilation.`