Skip to content

Fix remaining CI failures in PDF exporter test coverage branch#19

Merged
vitormattos merged 44 commits into
mainfrom
copilot/fix-composer-mutation-test-issues
May 29, 2026
Merged

Fix remaining CI failures in PDF exporter test coverage branch#19
vitormattos merged 44 commits into
mainfrom
copilot/fix-composer-mutation-test-issues

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 29, 2026

This PR clears the remaining PR CI failures: rector/lint were blocked by one outdated assertion pattern, and commitlint/dco were blocked by branch history metadata. The change keeps the test intent intact while aligning the branch with repository CI policy.

  • Test assertion cleanup

    • Replaced the last strpos(...) !== false assertion in SinglePagePdfExporterTest with a direct PHPUnit string assertion.
    • This removes the Rector diff and keeps the expectation readable alongside the adjacent PDF content checks.
  • Commit policy compliance

    • Reworked the branch commit history to use conventional commit messages.
    • Added Signed-off-by trailers so the branch satisfies DCO enforcement.
  • Affected surface

    • /tests/Unit/Pdf/SinglePagePdfExporterTest.php
    • PR commit metadata only; no production code changes
self::assertStringContainsString(
    "1 0 obj\n<< /Type /Catalog /Pages 2 0 R >>\nendobj\n2 0 obj",
    $rendered,
);
Original prompt

Estamos na main, porém quando rodo o composer mutation:test, está retornando muitos problemas, quero que resolva todos. Crie uma branch para isto, siga DCO, um commit por arquivo com -s, em todos os commits eu devo ser o autor. Siga conventional commits. Quero que este teste fique com tudo verde.

The user has attached the following file paths as relevant context:

  • .github/copilot-instructions.md

Created from VS Code.

Copilot AI changed the title [WIP] Fix composer mutation test issues test: harden mutation coverage for layout and PDF helpers May 29, 2026
Copilot AI requested a review from vitormattos May 29, 2026 14:14
@vitormattos

This comment was marked as off-topic.

@vitormattos

This comment was marked as off-topic.

This comment was marked as off-topic.

Copilot AI changed the title test: harden mutation coverage for layout and PDF helpers Fix remaining CI failures in PDF exporter test coverage branch May 29, 2026
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos force-pushed the copilot/fix-composer-mutation-test-issues branch from 520355a to 5818060 Compare May 29, 2026 15:51
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos marked this pull request as ready for review May 29, 2026 21:51
@vitormattos vitormattos merged commit 78e231f into main May 29, 2026
24 checks passed
@vitormattos vitormattos deleted the copilot/fix-composer-mutation-test-issues branch June 1, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants