Skip to content

Added best segment conversion #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aqua-md wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added best segment conversion #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c38c0f0
Added best segment conversion
aqua-md Apr 6, 2026
185896c
fixed typo in "elm_best_segments" variable name
aqua-md Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libresplit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ impl LibreSplitFile {
title: lss_split.name,
time: lss_split.split_time,
best_time: "0.000000".to_string(),
best_segment: "0.000000".to_string(),
best_segment: lss_split.best_segment,
};
splits.push(split);
}
Expand Down
20 changes: 19 additions & 1 deletion src/livesplit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,31 @@ impl LiveSplitFile {
}
None => "0.000000".to_string(),
};
let segment = Segment { name, split_time };

// Get best segment .
let elm_best_segments = elm_segment.opt("BestSegmentTime").element();
let best_segment = match elm_best_segments {
Some(elm_best_segment) => {
let elm_real_time = elm_best_segment.opt("RealTime").element();
match elm_real_time {
Some(real_time) => {
real_time.text().unwrap_or("0.000000").to_string()
}
None => "0.000000".to_string(), // default if element is missing.
}
}
None => "0.000000".to_string(),
};

let segment = Segment { name, split_time, best_segment };
segments.push(segment);
}
}
None => {
let placeholder = Segment {
name: "No Splits Provided".to_string(),
split_time: "0.000000".to_string(),
best_segment: "0.000000".to_string(),
};
segments.push(placeholder);
}
Expand All @@ -95,4 +112,5 @@ impl LiveSplitFile {
pub struct Segment {
pub name: String,
pub split_time: String,
pub best_segment: String,
}