Feedback#1
Open
github-classroom[bot] wants to merge 16 commits into
Open
Conversation
…impo, falta sleep mode
rafaelcorsi
reviewed
Nov 17, 2022
rafaelcorsi
left a comment
rafaelcorsi
left a comment
There was a problem hiding this comment.
pessoal parabéns pela entrega, gostei bastante, sem grandes comentários de código. Abraços, corsi
| BaseType_t xHigherPriorityTaskWoken = pdFALSE; | ||
| volatile Data data; | ||
| data.id = '1'; | ||
| data.value = 0; |
There was a problem hiding this comment.
eu não entendi o uso do data.value, se o que importa é o ID.
Comment on lines
+781
to
+795
| if (data.value == 0){ | ||
| if (data.button == '1' || data.button == '2' || data.button == '3' || data.button == '4'){ | ||
| pio_set(LED_PIO_BLUE, LED_IDX_MASK_BLUE); | ||
| } | ||
| else if (data.button == 'A' || data.button == 'B' || data.button == 'C' || data.button == 'D') { | ||
| pio_clear(LED_PIO_BLUE, LED_IDX_MASK_BLUE); | ||
| } | ||
| if (data.button == '5' || data.button == '6' || data.button == '7' || data.button == '8'){ | ||
| pio_set(LED_PIO_RED, LED_IDX_MASK_RED); | ||
| } | ||
| else if (data.button == 'E' || data.button == 'F' || data.button == 'G' || data.button == 'H') { | ||
| pio_clear(LED_PIO_RED, LED_IDX_MASK_RED); | ||
| } | ||
| send_package(data); | ||
| } |
There was a problem hiding this comment.
deve ter um jeito mais elegante de fazer isso, pelo menos encapsular em uma função já da uma melhorada. Não é algo que precisa mexer agora.
| valor_anterior_x = data.value; | ||
| } | ||
| } | ||
| if (data.id == 'J'){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mastersince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mastersince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.master. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @LidiaDomingos @listerogusuku