Refactor BaseRepository.list method#17
Open
stefanotroncaro wants to merge 1 commit into
Open
Conversation
stefanotroncaro
changed the title
stefanotroncaro
changed the title
DanTcheche
requested changes
Jul 4, 2025
DanTcheche
left a comment
DanTcheche
left a comment
Collaborator
There was a problem hiding this comment.
Nice work!
Please refactor this in other repositories so it's fixed across the project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session.query has been deprecated as of sqlalchemy v2, see the migration guide for context.
Refactored the BaseRepository.list method that used Query objects to use the preferred Select object.
I tested manually with various use cases to verify it works. I can write automated tests for the BaseRepository if its preferred, just leave a comment.