feat: add assertion for light/dark color list length parity#55
Open
deependujha wants to merge 1 commit into
Open
feat: add assertion for light/dark color list length parity#55deependujha wants to merge 1 commit into
deependujha wants to merge 1 commit into
Conversation
justusschock
requested changes
May 12, 2026
Member
justusschock
left a comment
There was a problem hiding this comment.
Assertions in production code should be avoided unless strictly required.
Author
|
So, are you in favour of using
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a module-level assertion to verify that
_LIGHT_THEME_COLORSand_DARK_THEME_COLORShave the same length.Why is this needed?
_create_colorscomputes an index againstlen(_DARK_THEME_COLORS)anduses it to index into both lists. If the two lists ever diverge in length
due to an accidental edit, the function would silently return a mismatched
color pair or raise an
IndexErrorat runtime with no clear indication ofthe root cause.
A module-level assertion catches this at import time, failing loudly and
immediately.
Changes
assert len(_LIGHT_THEME_COLORS) == len(_DARK_THEME_COLORS)witha descriptive error message after the color list definitions in
colors.py