From 0b7a3ef62ca0aea8d9cc3c13e0820f64992fe4ed Mon Sep 17 00:00:00 2001 From: deependujha Date: Tue, 12 May 2026 20:40:43 +0530 Subject: [PATCH 1/2] refactor: use random.choice over manual index arithmetic in name generation --- src/litlogger/generator.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/litlogger/generator.py b/src/litlogger/generator.py index 27bb703..eea0be8 100644 --- a/src/litlogger/generator.py +++ b/src/litlogger/generator.py @@ -1290,7 +1290,7 @@ def _create_name() -> str: if app_name and work_id: return "" - adjective = _ADJECTIVES[random.randint(0, len(_ADJECTIVES) - 1)] - color = _COLORS[random.randint(0, len(_COLORS) - 1)] - suffix = "".join(random.choice(string.ascii_letters) for _ in range(4)).lower() + adjective = random.choice(_ADJECTIVES) + color = random.choice(_COLORS) + suffix = "".join(random.choices(string.ascii_letters, k=4)).lower() return f"{adjective}-{color}-{suffix}" From ccb1c850acb4629f85c0e54446ba9238ee333902 Mon Sep 17 00:00:00 2001 From: deependujha Date: Thu, 28 May 2026 12:48:55 +0530 Subject: [PATCH 2/2] update --- tests/unittests/test_generator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unittests/test_generator.py b/tests/unittests/test_generator.py index 817ca9c..1299710 100644 --- a/tests/unittests/test_generator.py +++ b/tests/unittests/test_generator.py @@ -5,4 +5,4 @@ def test_generator(): random.seed(42) - assert _create_name() == "deaf-amber-vrpo" + assert _create_name() == "deaf-amber-mmhf"