Skip to content

fix race condition by defaulting to local mount prior to R2 fetch#821

Merged
tchaton merged 1 commit into
Lightning-AI:mainfrom
lianakoleva:lk/fix-local-race
May 18, 2026
Merged

fix race condition by defaulting to local mount prior to R2 fetch#821
tchaton merged 1 commit into
Lightning-AI:mainfrom
lianakoleva:lk/fix-local-race

Conversation

@lianakoleva
Copy link
Copy Markdown
Contributor

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fix a race condition where locally-accessible Lightning Storage input files were fetched from R2 but did not exist there yet. Now, Lightning Storage will be used when locally accessible.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 18, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81%. Comparing base (808fe07) to head (24cbf28).
⚠️ Report is 1 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #821   +/-   ##
===================================
  Coverage    81%    81%           
===================================
  Files        54     54           
  Lines      7617   7617           
===================================
+ Hits       6144   6146    +2     
+ Misses     1473   1471    -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tchaton tchaton merged commit a5ff05e into Lightning-AI:main May 18, 2026
46 of 48 checks passed
@lianakoleva lianakoleva deleted the lk/fix-local-race branch May 18, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants