Skip to content

fix(r2-downloader): reuse client for byte-range reads#840

Merged
bhimrazy merged 2 commits into
Lightning-AI:mainfrom
bhimrazy:fix/r2-download-bytes-client-reuse
Jul 14, 2026
Merged

fix(r2-downloader): reuse client for byte-range reads#840
bhimrazy merged 2 commits into
Lightning-AI:mainfrom
bhimrazy:fix/r2-download-bytes-client-reuse

Conversation

@bhimrazy

@bhimrazy bhimrazy commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator
Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes R2 byte-range downloads re-creating the client on every call by checking _client, the attribute actually used by the downloader.

PR review

Anyone in the community is free to review the PR once the tests have passed.

Did you have fun?

Yes.

@bhimrazy

Copy link
Copy Markdown
Collaborator Author

requires #841

@bhimrazy
bhimrazy enabled auto-merge (squash) July 14, 2026 10:05
@codecov-commenter

codecov-commenter commented Jul 14, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81%. Comparing base (9650501) to head (2f730cc).
⚠️ Report is 1 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #840   +/-   ##
===================================
  Coverage    81%    81%           
===================================
  Files        54     54           
  Lines      7671   7671           
===================================
+ Hits       6190   6198    +8     
+ Misses     1481   1473    -8     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bhimrazy
bhimrazy merged commit 72b25d8 into Lightning-AI:main Jul 14, 2026
35 checks passed
@bhimrazy
bhimrazy deleted the fix/r2-download-bytes-client-reuse branch July 14, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants