fix(tokenizer): extend decoding fix to cover Mistral no-spaces bug#2285
Open
eeshsaxena wants to merge 1 commit into
Open
fix(tokenizer): extend decoding fix to cover Mistral no-spaces bug#2285eeshsaxena wants to merge 1 commit into
eeshsaxena wants to merge 1 commit into
Conversation
eeshsaxena
requested review from
andyland,
k223kim and
lianakoleva
as code owners
July 15, 2026 09:07
Author
|
Closing to test the fix locally first and add a test case before resubmitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1822
When chatting with Mistral models, the output was missing spaces between words. This is because Mistral uses the same SentencePiece-backed tokenizer as LLaMA (both have the prefix-space issue documented in huggingface/transformers#31643).
The existing apply_decoding_fix only checked for 'LlamaTokenizer' in the tokenizer_class, but Mistral checkpoints report 'MistralTokenizer' or 'MistralTokenizerFast', so the fix was never applied for them.
Changes:
File changed: