Remove dead Python 3.9 guards and duplicate torch constant

Author: bhimrazy

src/lightning/fabric/utilities/imports.py

@@ -37,6 +37,5 @@
 _TORCH_GREATER_EQUAL_2_5 = compare_version("torch", operator.ge, "2.5.0")
 _TORCH_GREATER_EQUAL_2_6 = compare_version("torch", operator.ge, "2.6.0")
 _TORCH_LESS_EQUAL_2_6 = compare_version("torch", operator.le, "2.6.0")
-_TORCH_GREATER_EQUAL_2_6 = compare_version("torch", operator.ge, "2.6.0")
 _TORCHMETRICS_GREATER_EQUAL_1_0_0 = compare_version("torchmetrics", operator.ge, "1.0.0")
 _PYTHON_GREATER_EQUAL_3_10_0 = (sys.version_info.major, sys.version_info.minor) >= (3, 10)

tests/tests_pytorch/models/test_hparams.py

@@ -15,7 +15,6 @@
 import functools
 import os
 import pickle
-import sys
 from argparse import Namespace
 from dataclasses import dataclass, field
 from enum import Enum
@@ -46,8 +45,6 @@
     from omegaconf import Container, OmegaConf
     from omegaconf.dictconfig import DictConfig
 
-_PYTHON_GREATER_EQUAL_3_9_0 = (sys.version_info.major, sys.version_info.minor) >= (3, 9)
-
 
 class SaveHparamsModel(BoringModel):
     """Tests that a model can take an object."""
@@ -783,14 +780,6 @@ def test_model_with_fsspec_as_parameter(tmp_path):
     trainer.test(weights_only=weights_only)
 
 
-@pytest.mark.xfail(
-    # AttributeError: 'OrphanPath' object has no attribute 'exists'
-    # Issue with `importlib_resources>=6.2.0`
-    raises=AttributeError,
-    condition=(not _PYTHON_GREATER_EQUAL_3_9_0),
-    reason="Issue with `importlib_resources`",
-    strict=False,
-)
 @pytest.mark.skipif(RequirementCache("hydra-core<1.1"), reason="Requires Hydra's Compose API")
 def test_model_save_hyper_parameters_interpolation_with_hydra(tmp_path):
     """This test relies on configuration saved under tests/models/conf/config.yaml."""

tests/tests_pytorch/utilities/test_compile.py

@@ -25,8 +25,6 @@
 from tests_pytorch.conftest import mock_cuda_count
 from tests_pytorch.helpers.runif import RunIf
 
-_PYTHON_GREATER_EQUAL_3_9_0 = (sys.version_info.major, sys.version_info.minor) >= (3, 9)
-
 
 # https://github.com/pytorch/pytorch/issues/95708
 @pytest.mark.skipif(sys.platform == "darwin", reason="fatal error: 'omp.h' file not found")
@@ -157,7 +155,6 @@ def has_dynamo(fn):
 
 # https://github.com/pytorch/pytorch/issues/95708
 @pytest.mark.skipif(sys.platform == "darwin", reason="fatal error: 'omp.h' file not found")
-@pytest.mark.skipif(not _PYTHON_GREATER_EQUAL_3_9_0, reason="AssertionError: failed to reach fixed point")
 @pytest.mark.xfail(
     sys.platform == "win32" and _TORCH_GREATER_EQUAL_2_2, strict=False, reason="RuntimeError: Failed to import"
 )
@@ -188,7 +185,6 @@ def training_step(self, batch, batch_idx):
 
 # https://github.com/pytorch/pytorch/issues/95708
 @pytest.mark.skipif(sys.platform == "darwin", reason="fatal error: 'omp.h' file not found")
-@pytest.mark.skipif(not _PYTHON_GREATER_EQUAL_3_9_0, reason="AssertionError: failed to reach fixed point")
 @pytest.mark.xfail(
     sys.platform == "win32" and _TORCH_GREATER_EQUAL_2_2, strict=False, reason="RuntimeError: Failed to import"
 )