Skip to content

Commit da4f7ee

Browse files
authored
Remove dead jsonargparse<4.39 skip guards (#21848)
1 parent 8de4404 commit da4f7ee

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

tests/tests_pytorch/test_cli.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
import glob
1515
import inspect
1616
import json
17-
import operator
1817
import os
1918
from contextlib import ExitStack, contextmanager, redirect_stderr, redirect_stdout
2019
from io import StringIO
@@ -26,7 +25,6 @@
2625
import pytest
2726
import torch
2827
import yaml
29-
from lightning_utilities import compare_version
3028
from lightning_utilities.test.warning import no_warning_call
3129
from tensorboard.backend.event_processing import event_accumulator
3230
from tensorboard.plugins.hparams.plugin_data_pb2 import HParamsPluginData
@@ -258,9 +256,6 @@ def test_lightning_cli_args(cleandir):
258256
assert loaded_config["trainer"] == cli_config["trainer"]
259257

260258

261-
@pytest.mark.skipif(
262-
compare_version("jsonargparse", operator.lt, "4.39"), reason="incompatibilities with older jsonargparse"
263-
)
264259
def test_lightning_env_parse(cleandir):
265260
out = StringIO()
266261
with mock.patch("sys.argv", ["", "fit", "--help"]), redirect_stdout(out), pytest.raises(SystemExit):
@@ -427,9 +422,6 @@ def any_model_any_data_cli():
427422
LightningCLI(LightningModule, LightningDataModule, subclass_mode_model=True, subclass_mode_data=True)
428423

429424

430-
@pytest.mark.skipif(
431-
compare_version("jsonargparse", operator.lt, "4.39"), reason="incompatibilities with older jsonargparse"
432-
)
433425
def test_lightning_cli_help():
434426
cli_args = ["any.py", "fit", "--help"]
435427
out = StringIO()
@@ -1209,9 +1201,6 @@ def test_lightning_cli_subcommands():
12091201
assert e in parameters
12101202

12111203

1212-
@pytest.mark.skipif(
1213-
compare_version("jsonargparse", operator.lt, "4.39"), reason="incompatibilities with older jsonargparse"
1214-
)
12151204
def test_lightning_cli_custom_subcommand():
12161205
class TestTrainer(Trainer):
12171206
def foo(self, model: LightningModule, x: int, y: float = 1.0):

0 commit comments

Comments
 (0)