|
14 | 14 | import glob |
15 | 15 | import inspect |
16 | 16 | import json |
17 | | -import operator |
18 | 17 | import os |
19 | 18 | from contextlib import ExitStack, contextmanager, redirect_stderr, redirect_stdout |
20 | 19 | from io import StringIO |
|
26 | 25 | import pytest |
27 | 26 | import torch |
28 | 27 | import yaml |
29 | | -from lightning_utilities import compare_version |
30 | 28 | from lightning_utilities.test.warning import no_warning_call |
31 | 29 | from tensorboard.backend.event_processing import event_accumulator |
32 | 30 | from tensorboard.plugins.hparams.plugin_data_pb2 import HParamsPluginData |
@@ -258,9 +256,6 @@ def test_lightning_cli_args(cleandir): |
258 | 256 | assert loaded_config["trainer"] == cli_config["trainer"] |
259 | 257 |
|
260 | 258 |
|
261 | | -@pytest.mark.skipif( |
262 | | - compare_version("jsonargparse", operator.lt, "4.39"), reason="incompatibilities with older jsonargparse" |
263 | | -) |
264 | 259 | def test_lightning_env_parse(cleandir): |
265 | 260 | out = StringIO() |
266 | 261 | with mock.patch("sys.argv", ["", "fit", "--help"]), redirect_stdout(out), pytest.raises(SystemExit): |
@@ -427,9 +422,6 @@ def any_model_any_data_cli(): |
427 | 422 | LightningCLI(LightningModule, LightningDataModule, subclass_mode_model=True, subclass_mode_data=True) |
428 | 423 |
|
429 | 424 |
|
430 | | -@pytest.mark.skipif( |
431 | | - compare_version("jsonargparse", operator.lt, "4.39"), reason="incompatibilities with older jsonargparse" |
432 | | -) |
433 | 425 | def test_lightning_cli_help(): |
434 | 426 | cli_args = ["any.py", "fit", "--help"] |
435 | 427 | out = StringIO() |
@@ -1209,9 +1201,6 @@ def test_lightning_cli_subcommands(): |
1209 | 1201 | assert e in parameters |
1210 | 1202 |
|
1211 | 1203 |
|
1212 | | -@pytest.mark.skipif( |
1213 | | - compare_version("jsonargparse", operator.lt, "4.39"), reason="incompatibilities with older jsonargparse" |
1214 | | -) |
1215 | 1204 | def test_lightning_cli_custom_subcommand(): |
1216 | 1205 | class TestTrainer(Trainer): |
1217 | 1206 | def foo(self, model: LightningModule, x: int, y: float = 1.0): |
|
0 commit comments