fix: PermissionError swallowing in _atomic_save#21799
Open
zhixiangli wants to merge 2 commits into
Open
Conversation
_atomic_save was silently swallowing non-cross-device PermissionErrors. This caused FSDP saves to silently fail (e.g. on permission denied writes to a bucket or read-only mount) while reporting success. We now re-raise the PermissionError if it is not the specific EXDEV cross-device error. TAG=agy CONV=6de87715-4fba-4a08-be33-6aa377349f77
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21799 +/- ##
=======================================
Coverage 87% 87%
=======================================
Files 270 270
Lines 24010 24011 +1
=======================================
+ Hits 20787 20789 +2
+ Misses 3223 3222 -1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #21800
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist