feat(FSDP): enable FSDP strategy on CPU and add trainable checkpointing tests#21840
Open
zhixiangli wants to merge 4 commits into
Open
feat(FSDP): enable FSDP strategy on CPU and add trainable checkpointing tests#21840zhixiangli wants to merge 4 commits into
zhixiangli wants to merge 4 commits into
Conversation
zhixiangli
requested review from
ethanwharris,
justusschock and
tchaton
as code owners
July 17, 2026 01:19
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #21840 +/- ##
=========================================
- Coverage 87% 79% -8%
=========================================
Files 270 267 -3
Lines 24069 24011 -58
=========================================
- Hits 20904 18868 -2036
- Misses 3165 5143 +1978 |
zhixiangli
force-pushed
the
feature/fsdp-cpu
branch
from
July 17, 2026 14:03
2aea2dc to
05941d4
Compare
This enables using FSDP strategy with `accelerator="cpu"`, which is useful for CPU-based FSDP checkpoint benchmarking and testing. Also updated CHANGELOG.md and added tests. TAG=agy CONV=0b443e3e-6fbb-468a-9f11-b99f211cf34b
for more information, see https://pre-commit.ci
TAG=agy CONV=e53a2100-ddf2-4298-b123-6e1312841db7
for more information, see https://pre-commit.ci
zhixiangli
force-pushed
the
feature/fsdp-cpu
branch
from
July 22, 2026 04:28
5e2f952 to
a3e129a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #21812
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist