Remove dead Python 3.9 guards and duplicate torch constant#21847
Merged
tchaton merged 1 commit intoJul 20, 2026
Conversation
bhimrazy
requested review from
ethanwharris,
justusschock and
tchaton
as code owners
July 19, 2026 15:59
bhimrazy
force-pushed
the
cleanup/dead-version-guards
branch
from
July 19, 2026 16:01
b78185d to
811ef26
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21847 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 270 270
Lines 24074 24073 -1
=======================================
- Hits 20906 20902 -4
- Misses 3168 3171 +3 |
This was referenced Jul 19, 2026
tchaton
approved these changes
Jul 20, 2026
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small dead-code cleanup:
_TORCH_GREATER_EQUAL_2_6definition infabric/utilities/imports.py._PYTHON_GREATER_EQUAL_3_9_0guards intest_compile.pyandtest_hparams.py— the minimum supported Python is 3.10, so these are always true (and thetest_hparamsxfailcondition never triggered).