Skip to content

Remove dead Python 3.9 guards and duplicate torch constant#21847

Merged
tchaton merged 1 commit into
Lightning-AI:masterfrom
bhimrazy:cleanup/dead-version-guards
Jul 20, 2026
Merged

Remove dead Python 3.9 guards and duplicate torch constant#21847
tchaton merged 1 commit into
Lightning-AI:masterfrom
bhimrazy:cleanup/dead-version-guards

Conversation

@bhimrazy

@bhimrazy bhimrazy commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Small dead-code cleanup:

  • Remove the duplicate _TORCH_GREATER_EQUAL_2_6 definition in fabric/utilities/imports.py.
  • Drop _PYTHON_GREATER_EQUAL_3_9_0 guards in test_compile.py and test_hparams.py — the minimum supported Python is 3.10, so these are always true (and the test_hparams xfail condition never triggered).

@bhimrazy
bhimrazy force-pushed the cleanup/dead-version-guards branch from b78185d to 811ef26 Compare July 19, 2026 16:01
@codecov-commenter

codecov-commenter commented Jul 19, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (fbdf042) to head (811ef26).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #21847   +/-   ##
=======================================
- Coverage      87%      87%   -0%     
=======================================
  Files         270      270           
  Lines       24074    24073    -1     
=======================================
- Hits        20906    20902    -4     
- Misses       3168     3171    +3     

@tchaton
tchaton merged commit 7f0c343 into Lightning-AI:master Jul 20, 2026
291 of 297 checks passed
@mergify

mergify Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@bhimrazy
bhimrazy deleted the cleanup/dead-version-guards branch July 20, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants