Skip to content

Remove dead jsonargparse<4.39 skip guards #21848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tchaton merged 1 commit into from
Jul 20, 2026
+0 −11
Merged

Remove dead jsonargparse<4.39 skip guards #21848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions tests/tests_pytorch/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
import glob
import inspect
import json
import operator
import os
from contextlib import ExitStack, contextmanager, redirect_stderr, redirect_stdout
from io import StringIO
Expand All @@ -26,7 +25,6 @@
import pytest
import torch
import yaml
from lightning_utilities import compare_version
from lightning_utilities.test.warning import no_warning_call
from tensorboard.backend.event_processing import event_accumulator
from tensorboard.plugins.hparams.plugin_data_pb2 import HParamsPluginData
Expand Down Expand Up @@ -258,9 +256,6 @@ def test_lightning_cli_args(cleandir):
assert loaded_config["trainer"] == cli_config["trainer"]


@pytest.mark.skipif(
compare_version("jsonargparse", operator.lt, "4.39"), reason="incompatibilities with older jsonargparse"
)
def test_lightning_env_parse(cleandir):
out = StringIO()
with mock.patch("sys.argv", ["", "fit", "--help"]), redirect_stdout(out), pytest.raises(SystemExit):
Expand Down Expand Up @@ -427,9 +422,6 @@ def any_model_any_data_cli():
LightningCLI(LightningModule, LightningDataModule, subclass_mode_model=True, subclass_mode_data=True)


@pytest.mark.skipif(
compare_version("jsonargparse", operator.lt, "4.39"), reason="incompatibilities with older jsonargparse"
)
def test_lightning_cli_help():
cli_args = ["any.py", "fit", "--help"]
out = StringIO()
Expand Down Expand Up @@ -1209,9 +1201,6 @@ def test_lightning_cli_subcommands():
assert e in parameters


@pytest.mark.skipif(
compare_version("jsonargparse", operator.lt, "4.39"), reason="incompatibilities with older jsonargparse"
)
def test_lightning_cli_custom_subcommand():
class TestTrainer(Trainer):
def foo(self, model: LightningModule, x: int, y: float = 1.0):
Expand Down
Loading