fix(ci): align greetings workflow inputs with first-interaction@v3#3365
Conversation
The v3 action renamed inputs from kebab-case to snake_case. Rename repo-token/issue-message/pr-message to the new names so the workflow stops failing on every new issue and PR
|
Heads-up: the two failing |
|
@ethanwharris @justusschock could you please review this PR? Thanks! |
|
@RecreationalMath while on it, could we also pin the workflow sha? |
Done, pinned Heads up: this is currently the only SHA-pinned action in the repo, 41 other |
|
@RecreationalMath if you want to do that it'd be much appreciated. It's definitely on our list todo for all workflows/actions |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3365 +/- ##
======================================
Coverage 37% 37%
======================================
Files 349 349
Lines 19901 19901
======================================
Hits 7264 7264
Misses 12637 12637 🚀 New features to boost your workflow:
|
Opened #3392 for this. |
What does this PR do?
The greetings workflow fails on every new issue/PR because
actions/first-interaction@v3renamed its inputs from kebab-case to snake_case. This PR updates the three input keys:repo-token->repo_tokenissue-message->issue_messagepr-message->pr_messageNo message or behaviour changes. Example failing run: 24886149392 (triggered by opening #3364).
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Oh yes, small kick of knowing no new contributor will get "[Lightning-AI/torchmetrics] Run failed: Greetings" as their welcome email anymore.
📚 Documentation preview 📚: https://torchmetrics--3365.org.readthedocs.build/en/3365/