Skip to content

fix(ci): align greetings workflow inputs with first-interaction@v3#3365

Merged
justusschock merged 3 commits into
Lightning-AI:masterfrom
RecreationalMath:fix/greetings-action-v3-inputs
May 21, 2026
Merged

fix(ci): align greetings workflow inputs with first-interaction@v3#3365
justusschock merged 3 commits into
Lightning-AI:masterfrom
RecreationalMath:fix/greetings-action-v3-inputs

Conversation

@RecreationalMath
Copy link
Copy Markdown
Contributor

@RecreationalMath RecreationalMath commented Apr 24, 2026

What does this PR do?

The greetings workflow fails on every new issue/PR because actions/first-interaction@v3 renamed its inputs from kebab-case to snake_case. This PR updates the three input keys:

  • repo-token -> repo_token
  • issue-message -> issue_message
  • pr-message -> pr_message

No message or behaviour changes. Example failing run: 24886149392 (triggered by opening #3364).

Before submitting
  • (Not required, because typo PR) Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • (Not required) Did you make sure to update the docs?
  • (Not required) Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Oh yes, small kick of knowing no new contributor will get "[Lightning-AI/torchmetrics] Run failed: Greetings" as their welcome email anymore.


📚 Documentation preview 📚: https://torchmetrics--3365.org.readthedocs.build/en/3365/

The v3 action renamed inputs from kebab-case to snake_case.
Rename repo-token/issue-message/pr-message to the new names
so the workflow stops failing on every new issue and PR
@RecreationalMath
Copy link
Copy Markdown
Contributor Author

Heads-up: the two failing unittests.yml / Lit Job checks look unrelated to this PR. This PR only renames three input keys in .github/workflows/greetings.yml and doesn't touch any Python or test code.

@RecreationalMath
Copy link
Copy Markdown
Contributor Author

@ethanwharris @justusschock could you please review this PR? Thanks!

@justusschock
Copy link
Copy Markdown
Member

@RecreationalMath while on it, could we also pin the workflow sha?

@RecreationalMath
Copy link
Copy Markdown
Contributor Author

@RecreationalMath while on it, could we also pin the workflow sha?

Done, pinned actions/first-interaction to 1c46889 (v3.1.0).

Heads up: this is currently the only SHA-pinned action in the repo, 41 other uses: references across 11 workflows + 2 composite actions are on mutable tags (19 actions/*, 6 Lightning-AI/utilities, 16 third-party). Happy to open a follow-up PR to pin them, scoped however you prefer (third-party only, or everything). Since the repo's Dependabot already covers github-actions, it would keep the pinned SHAs up to date, so pinning wouldn't introduce any staleness. Let me know what you'd like @justusschock

@mergify mergify Bot requested a review from a team May 21, 2026 06:09
@justusschock
Copy link
Copy Markdown
Member

@RecreationalMath if you want to do that it'd be much appreciated. It's definitely on our list todo for all workflows/actions

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 21, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37%. Comparing base (d184220) to head (7957dd0).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3365   +/-   ##
======================================
  Coverage      37%     37%           
======================================
  Files         349     349           
  Lines       19901   19901           
======================================
  Hits         7264    7264           
  Misses      12637   12637           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justusschock justusschock merged commit c18ea1d into Lightning-AI:master May 21, 2026
57 checks passed
@RecreationalMath
Copy link
Copy Markdown
Contributor Author

@RecreationalMath if you want to do that it'd be much appreciated. It's definitely on our list todo for all workflows/actions

Opened #3392 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants