New Metric: Soft Dynamic Time Warping (Soft-DTW)#3287
New Metric: Soft Dynamic Time Warping (Soft-DTW)#3287VijayVignesh1 wants to merge 17 commits intoLightning-AI:masterfrom
Soft Dynamic Time Warping (Soft-DTW)#3287Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@Borda Just wanted to get your initial opinion on this before I move forward. The softDTW uses dynamic programming which makes it really slow to work with on cpus. It's runs faster on gpus. Do you think it's worth continuing the effort? |
I think it is very fine to have only the GPU version and raise an exception or a warning on the CPU |
Soft Dtw Loss [WIP]Soft Dtw Loss [WIP]
Soft Dtw Loss [WIP]Soft Dynamic Time Warping (Soft-DTW)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@justusschock I'm looking at the unittest results. Turns out it's erroring out: The pysdtw library used as reference needs it. Is there any way around it? |
|
@VijayVignesh1 not fully sure, but you could just add that libs installation to the docker command in .lightning/workloads. |
@justusschock I removed the cuda usage in reference implementation and everything works fine now. |
Codecov Report❌ Patch coverage is ❌ Your project check has failed because the head coverage (37%) is below the target coverage (95%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3287 +/- ##
=======================================
- Coverage 37% 37% -1%
=======================================
Files 364 353 -11
Lines 20096 19998 -98
=======================================
- Hits 7520 7361 -159
- Misses 12576 12637 +61 🚀 New features to boost your workflow:
|
What does this PR do?
Fixes #3084
Before submitting
PR review
Added a new domain called timeseries to include Soft DTW loss.
Ref paper: https://arxiv.org/abs/1703.01541
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--3287.org.readthedocs.build/en/3287/