fix(ci): align greetings workflow inputs with first-interaction@v3#3365
Open
RecreationalMath wants to merge 1 commit intoLightning-AI:masterfrom
Open
fix(ci): align greetings workflow inputs with first-interaction@v3#3365RecreationalMath wants to merge 1 commit intoLightning-AI:masterfrom
RecreationalMath wants to merge 1 commit intoLightning-AI:masterfrom
Conversation
The v3 action renamed inputs from kebab-case to snake_case. Rename repo-token/issue-message/pr-message to the new names so the workflow stops failing on every new issue and PR
RecreationalMath
requested review from
ethanwharris and
justusschock
as code owners
Author
|
Heads-up: the two failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The greetings workflow fails on every new issue/PR because
actions/first-interaction@v3renamed its inputs from kebab-case to snake_case. This PR updates the three input keys:repo-token->repo_tokenissue-message->issue_messagepr-message->pr_messageNo message or behaviour changes. Example failing run: 24886149392 (triggered by opening #3364).
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Oh yes, small kick of knowing no new contributor will get "[Lightning-AI/torchmetrics] Run failed: Greetings" as their welcome email anymore.
📚 Documentation preview 📚: https://torchmetrics--3365.org.readthedocs.build/en/3365/