[PoC] Add MetaLearning support through learn2learn by tchaton · Pull Request #737 · Lightning-Universe/lightning-flash

tchaton · 2021-09-06T18:51:47Z

What does this PR do?

Here is the PR from the learn2learn side: learnables/learn2learn#257

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes?
Did you write any new necessary tests? [not needed for typos/docs]
Did you verify new and existing tests pass locally with your changes?
If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

codecov · 2021-09-06T18:55:34Z

Codecov Report

Merging #737 (fd2cce5) into master (c2095d3) will decrease coverage by 0.43%.
The diff coverage is 76.58%.

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage   90.21%   89.77%   -0.44%     
==========================================
  Files         199      201       +2     
  Lines       10688    11011     +323     
==========================================
+ Hits         9642     9885     +243     
- Misses       1046     1126      +80

Flag	Coverage Δ
unittests	`89.77% <76.58%> (-0.44%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
flash/core/data/data_module.py	`94.50% <ø> (ø)`
flash/pointcloud/detection/model.py	`82.25% <ø> (ø)`
flash/pointcloud/segmentation/model.py	`76.13% <ø> (ø)`
flash/image/data.py	`86.66% <22.22%> (-8.79%)`	⬇️
...h/image/classification/integrations/learn2learn.py	`54.79% <54.79%> (ø)`
flash/image/classification/adapters.py	`82.02% <82.02%> (ø)`
flash/core/classification.py	`94.11% <83.33%> (-1.72%)`	⬇️
flash/image/classification/model.py	`76.59% <84.21%> (-0.33%)`	⬇️
flash/core/adapter.py	`94.44% <100.00%> (+0.44%)`	⬆️
flash/core/data/data_pipeline.py	`95.81% <100.00%> (ø)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2095d3...fd2cce5. Read the comment docs.

ethanwharris

Awesome 😃

Borda

do we have a task, real example, competition to test it on?

pietrolesci · 2021-09-07T10:23:44Z

Adding to @Borda's comment, an easy way to test whether it's working properly is to replicate the examples in this folder of the l2l library (note: link to vision examples). As soon as the discussion around the API is addressed, I can help replicating some examples

for more information, see https://pre-commit.ci

ethanwharris

Looking good 😃

ethanwharris · 2021-09-07T15:25:16Z

+    def __init__(self, task: AdapterTask, backbone: torch.nn.Module, head: torch.nn.Module):
+        super().__init__()
+
+        self._task = NoModule(task)


Could we just move out the base *_step implementations to a mixin to just inherit the behaviour rather than have a reference to the task?

Not sure to understand you. I did it this way, so we can use Task.training_step(self.task, batch, batch_idx) in the training_step of the adapter.

Yeah, but we could just move the Task.*_step methods out somehwere so that they can be included in the base task but also in adapters. That way the base adapter and base task could both have the base step methods and you could just do super().*_step to get access to it.

pietrolesci

Neat, looking great!

…htning-flash into learn2learn

ethanwharris

LGTM 😃

…htning-flash into learn2learn

update

4272598

tchaton requested review from Borda, ananyahjha93, carmocca, ethanwharris, justusschock and kaushikb11 as code owners September 6, 2021 18:51

ethanwharris reviewed Sep 6, 2021

View reviewed changes

Comment thread flash/core/utilities/providers.py Outdated

Comment thread flash/image/classification/adapters.py Outdated

Borda reviewed Sep 6, 2021

View reviewed changes

tchaton added 2 commits September 7, 2021 11:44

update

73ec02e

update

986dfe0

mergify Bot added the has conflicts label Sep 7, 2021

tchaton added 2 commits September 7, 2021 15:43

update

17267a8

Merge branch 'master' into learn2learn

a3364a5

mergify Bot removed the has conflicts label Sep 7, 2021

[pre-commit.ci] auto fixes from pre-commit.com hooks

b33beb7

for more information, see https://pre-commit.ci

tchaton mentioned this pull request Sep 7, 2021

[Feat] Add support for distributed training learnables/learn2learn#257

Open

4 tasks

ananyahjha93 approved these changes Sep 7, 2021

View reviewed changes

ethanwharris reviewed Sep 7, 2021

View reviewed changes

pietrolesci reviewed Sep 7, 2021

View reviewed changes

Comment thread flash/core/utilities/imports.py Outdated

pietrolesci reviewed Sep 7, 2021

View reviewed changes

Comment thread requirements/datatype_image_extras.txt Outdated

tchaton added 6 commits September 8, 2021 11:19

wip

1bc4298

Merge branch 'learn2learn' of https://github.com/PyTorchLightning/lig…

70ff518

…htning-flash into learn2learn

update

1af0544

Merge branch 'master' into learn2learn

084721c

update imports

c9c3a21

simplification

3b762f2

mergify Bot removed the has conflicts label Sep 13, 2021

ethanwharris added 2 commits September 13, 2021 10:38

Update CHANGELOG.md

a802ec7

Update CHANGELOG.md

43d201f

pietrolesci reviewed Sep 14, 2021

View reviewed changes

Comment thread flash/image/classification/model.py Outdated

pietrolesci reviewed Sep 14, 2021

View reviewed changes

Comment thread flash/image/classification/adapters.py

update

47dace8

mergify Bot added the has conflicts label Sep 14, 2021

pietrolesci reviewed Sep 17, 2021

View reviewed changes

Comment thread flash/image/classification/model.py Outdated

tchaton added 2 commits September 20, 2021 10:49

update example

baa1fcf

Merge branch 'master' into learn2learn

8280807

mergify Bot removed the has conflicts label Sep 20, 2021

tchaton and others added 8 commits September 20, 2021 10:53

update

01b2049

update on comments

6928d10

Merge branch 'learn2learn' of https://github.com/PyTorchLightning/lig…

40c827d

…htning-flash into learn2learn

update

c040b5c

update

e95d565

remove typing

a903cd2

update

cd91b53

Update gpu-tests.yml

7376197

ethanwharris approved these changes Sep 20, 2021

View reviewed changes

tchaton added 2 commits September 20, 2021 12:09

update

d2e22ec

Merge branch 'learn2learn' of https://github.com/PyTorchLightning/lig…

9b2b2bf

…htning-flash into learn2learn

ethanwharris reviewed Sep 20, 2021

View reviewed changes

Comment thread requirements/datatype_image_extras.txt Outdated

Comment thread .azure-pipelines/gpu-tests.yml Outdated

ethanwharris and others added 5 commits September 20, 2021 12:17

Apply suggestions from code review

1c8660f

resolve test

3b28379

Merge branch 'learn2learn' of https://github.com/PyTorchLightning/lig…

65d3b06

…htning-flash into learn2learn

Merge branch 'master' into learn2learn

a06546a

update

fd2cce5

tchaton merged commit 991fdf0 into master Sep 20, 2021

tchaton deleted the learn2learn branch September 20, 2021 12:37

Conversation

tchaton commented Sep 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Before submitting

PR review

Did you have fun?

Uh oh!

codecov Bot commented Sep 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ethanwharris left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Borda left a comment

Choose a reason for hiding this comment

Uh oh!

pietrolesci commented Sep 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ethanwharris left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ethanwharris Sep 7, 2021

Choose a reason for hiding this comment

Uh oh!

tchaton Sep 8, 2021

Choose a reason for hiding this comment

Uh oh!

ethanwharris Sep 8, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pietrolesci left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ethanwharris left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tchaton commented Sep 6, 2021 •

edited

Loading

codecov Bot commented Sep 6, 2021 •

edited

Loading

pietrolesci commented Sep 7, 2021 •

edited

Loading