Skip to content

Commit 858f448

Browse files
committed
validate: check that run.steps exists in test definitions
validate.py only checked metadata keys. A test definition without run.steps is not valid but was not caught. Add a check for run.steps after the existing metadata validation. Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
1 parent 6401484 commit 858f448

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

validate.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,13 @@ def validate_testdef_yaml(y, args):
143143
publish_result(result_message_list, args)
144144
args.failed_message_list = args.failed_message_list + result_message_list
145145
return 1
146+
# check run.steps exists
147+
if "run" not in y or "steps" not in y.get("run", {}):
148+
result_message_list.append("* METADATA [FAILED]: " + filepath)
149+
result_message_list.append("\trun.steps section missing")
150+
publish_result(result_message_list, args)
151+
args.failed_message_list = args.failed_message_list + result_message_list
152+
return 1
146153

147154
result_message_list.append("* METADATA [PASSED]: " + filepath)
148155
publish_result(result_message_list, args)

0 commit comments

Comments
 (0)