Skip to content

support LTOA#507

Merged
juliocelon merged 11 commits into
LinearTapeFileSystem:v2.4-stablefrom
Magic-Kowel:LTOA_Support
Apr 23, 2025
Merged

support LTOA#507
juliocelon merged 11 commits into
LinearTapeFileSystem:v2.4-stablefrom
Magic-Kowel:LTOA_Support

Conversation

@Magic-Kowel

@Magic-Kowel Magic-Kowel commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Summary of changes

This pull request includes following changes or fixes.

  • Support to LTOA Tape

Description

Support to LTOA LTFS was updated for use the new tape LTOA

Fixes #issue_no

Type of change

Please delete items that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have confirmed my fix is effective or that my feature works

@Magic-Kowel Magic-Kowel marked this pull request as draft April 10, 2025 22:23
@Magic-Kowel Magic-Kowel marked this pull request as ready for review April 10, 2025 22:23
@vandelvan vandelvan requested a review from syaoraang April 11, 2025 16:29
@juliocelon juliocelon requested a review from piste-jp April 14, 2025 17:25
chukero
chukero approved these changes Apr 14, 2025
View reviewed changes

@chukero chukero left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

piste-jp
piste-jp reviewed Apr 15, 2025
View reviewed changes
Comment thread src/tape_drivers/ibm_tape.c
piste-jp
piste-jp reviewed Apr 15, 2025
View reviewed changes

@piste-jp piste-jp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks almost good.

But please check my comments about density support table.

Comment thread src/tape_drivers/ibm_tape.c Outdated
vandelvan
vandelvan approved these changes Apr 15, 2025
View reviewed changes

@vandelvan vandelvan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Magic-Kowel Looks good, thanks!

syaoraang
syaoraang approved these changes Apr 15, 2025
View reviewed changes

@syaoraang syaoraang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me!

juliocelon
juliocelon approved these changes Apr 16, 2025
View reviewed changes

@juliocelon juliocelon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, Josue! Thank you!!

amissael95
amissael95 reviewed Apr 17, 2025
View reviewed changes

@amissael95 amissael95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Magic-Kowel. Good job! Just smalls comments regarding the indentation.

Could you also add the tests you did to confirm that this change is functional using ltfs ?

Comment thread src/tape_drivers/ibm_tape.c Outdated
Comment thread src/tape_drivers/hp_tape.c Outdated
vandelvan
vandelvan requested changes Apr 17, 2025
View reviewed changes

@vandelvan vandelvan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Magic-Kowel sorry for changing my review until now, but I did not notice it before, please update the timeout values.

Comment thread src/tape_drivers/hp_tape.c Outdated
Comment thread src/tape_drivers/ibm_tape.c Outdated
Comment thread src/tape_drivers/ibm_tape.c
Comment thread src/tape_drivers/quantum_tape.c
piste-jp
piste-jp approved these changes Apr 22, 2025
View reviewed changes

@piste-jp piste-jp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vandelvan
vandelvan approved these changes Apr 23, 2025
View reviewed changes

@vandelvan vandelvan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments! Good to go!

amissael95
amissael95 approved these changes Apr 23, 2025
View reviewed changes

@amissael95 amissael95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Magic-Kowel Thanks for all your efforts, approved!

@juliocelon juliocelon merged commit 0971dec into LinearTapeFileSystem:v2.4-stable Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amissael95 amissael95 amissael95 approved these changes

@syaoraang syaoraang syaoraang approved these changes

@juliocelon juliocelon juliocelon approved these changes

@vandelvan vandelvan vandelvan approved these changes

@chukero chukero chukero approved these changes

@XV02 XV02 Awaiting requested review from XV02

@rangelmx rangelmx Awaiting requested review from rangelmx

+1 more reviewer

@piste-jp piste-jp piste-jp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Magic-Kowel Magic-Kowel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Magic-Kowel @amissael95 @syaoraang @piste-jp @juliocelon @vandelvan @chukero @rangelmx