Windows support#520
Conversation
|
Sorry, I cannot understand what is changed form #510. I would like to ask you below.
I would like to provide a base branch which provides more comfortable Please let me have a few days. |
juliocelon
left a comment
There was a problem hiding this comment.
Thanks so much for all your hard work, Gustavo!
amissael95
left a comment
There was a problem hiding this comment.
Approved, the merge can be done to the branch "v2.4.8-windows" since it would not affect any stable branch.
piste-jp
left a comment
There was a problem hiding this comment.
Looks good because this merge might be done to [2.4.8-windows-support](https://github.com/LinearTapeFileSystem/ltfs/tree/v2.4.8-windows-support) branch.
syaoraang
left a comment
There was a problem hiding this comment.
Time is in our shoulder,s but more review will be performed later.
Approved but need to be improved later with everyones review.
dce31f8
into
LinearTapeFileSystem:v2.4.8-windows-support
Summary of changes
This pull request includes following changes or fixes.
Description
Code was updated to be compatible again with Windows platform. Microsoft mandates compilation with Microsoft tools to give support, with that said the code needed to be compatible with Microsoft Visual C++ Compiler for a new version to be built.
Macros we're added to comply with this and change the behavior depending on which platform the project is being built.
Type of change
Checklist: