Set NA to GCC Version in Windows#536
Merged
juliocelon merged 2 commits intoLinearTapeFileSystem:v2.4.8-windows-supportfrom Aug 11, 2025
Merged
Set NA to GCC Version in Windows#536juliocelon merged 2 commits intoLinearTapeFileSystem:v2.4.8-windows-supportfrom
juliocelon merged 2 commits intoLinearTapeFileSystem:v2.4.8-windows-supportfrom
Conversation
Member
Author
|
Regarding crash on binaries on version 2.4.8.0 10517, this is the output when you try to get default help in ltfsck.exe After changesltfsck.exe |
madjesc
approved these changes
Aug 3, 2025
Member
Author
|
Test on Linux: Test on Windows: |
vandelvan
approved these changes
Aug 6, 2025
Member
vandelvan
left a comment
There was a problem hiding this comment.
Great for supporting multiplatform.
Thanks!
amissael95
approved these changes
Aug 7, 2025
Contributor
amissael95
left a comment
There was a problem hiding this comment.
@Piloalucard thanks for working on this change and make emphasis on the MSVC usage on windows. Approved!
1628440
into
LinearTapeFileSystem:v2.4.8-windows-support
8 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GCC
__VERSION__Macro is undefined on the new compilation process in windows, causing crash in binariesFixes #534
Type of change
Checklist: