Add --client-id flag#73
Open
elovelan wants to merge 2 commits into
Open
Conversation
elovelan
marked this pull request as draft
July 16, 2026 19:24
Per https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app#generating-a-json-web-token-jwt, GitHub now recommends using the client ID as the JWT `iss` claim instead of the app ID. Introduce `--client-id` as a new flag with `--app-id` supported for backwards- compatibility. If both are provided, `--client-id` is used.
Per GitHub and common OAuth guidance, the client ID does not need to be secret: https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/making-authenticated-api-requests-with-a-github-app-in-a-github-actions-workflow#authenticating-with-a-github-app
elovelan
marked this pull request as ready for review
July 16, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub now recommends using the client ID as the JWT
issclaim instead of the app ID.Introduces
--client-idas a new flag with--app-idsupported for backwards-compatibility. If both are provided,
--client-idis used.Tests and docs updated.
Also updates the workflow example to match GitHub's example of using a variable instead of a secret for the client ID, since it isn't a sensitive value.