[Test] application 테스트 및 커버리지 실행 Gradle 태스크 추가#63
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 48 minutes and 52 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughGradle 빌드 구성에 JaCoCo 코드 커버리지 플러그인 및 기능을 추가했습니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@linktrip-domain-test/build.gradle.kts`:
- Around line 57-64: The exec block invoking the Gradle wrapper uses a hardcoded
Unix executable ("./gradlew") which will fail on Windows; update the exec in
build.gradle.kts so the commandLine is chosen based on the OS (e.g., detect
System.getProperty("os.name") or use org.gradle.internal.os.OperatingSystem) and
use "./gradlew" on Unix-like systems and "gradlew.bat" (without "./") on Windows
when building the command for the exec { ... } block that currently calls
commandLine("./gradlew", "--rerun-tasks",
":linktrip-application:applicationTest",
":linktrip-application:applicationTestCoverage"); ensure workingDir remains
file("..") and preserve the same args order.
- Around line 12-49: The current exec blocks hardcode Chrome and let failures
fail the Gradle task; change each exec invocation that launches the report (the
blocks that call "Start-Process chrome", "powershell" with Chrome, "open -a
Google Chrome", and "xdg-open") to launch the system default browser instead and
make the exec non-fatal: use the OS-appropriate default-open command (e.g., on
mac use "open" without "-a Google Chrome", on Windows call
powershell/Start-Process with the report URI but not forcing chrome, and on WSL
convert path then call the Windows default opener) and set the exec to ignore
failures (set isIgnoreExitValue = true inside the exec or wrap the exec call in
try/catch and swallow the exception while logging a warning); update the blocks
that use reportPath and reportFile.toURI() accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ebc0f56c-9604-45e3-82ea-af442e63dae8
📒 Files selected for processing (4)
linktrip-application/build.gradle.ktslinktrip-domain-test/build.gradle.ktslinktrip-domain-test/settings.gradle.ktssettings.gradle.kts
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: 자동 검증 (ktlint + test)
🔇 Additional comments (4)
linktrip-domain-test/settings.gradle.kts (1)
1-1: 컴포지트 빌드 이름 지정이 명확합니다.
includeBuild("linktrip-domain-test")와 조합될 때 식별성이 좋아서 유지보수에 유리합니다.settings.gradle.kts (1)
21-21: 컴포지트 빌드 추가 방향이 적절합니다.Line 21의
includeBuild("linktrip-domain-test")로 테스트 전용 빌드를 분리한 구성이 의도와 잘 맞습니다.linktrip-application/build.gradle.kts (2)
10-21:applicationTest태스크 분리가 깔끔합니다.테스트 범위 제한, JUnit Platform, 로그 이벤트 설정이 모두 목적에 맞게 구성되었습니다.
23-49: 커버리지 태스크 및 기본 테스트 리포트 연계가 잘 구성되었습니다.
applicationTestCoverage정의와test/jacocoTestReport연결이 명확해서 실행 동선이 예측 가능합니다.
1 participant
관련 이슈
변경 내용
linktrip-domain-testincluded build를 추가해 IntelliJ Gradle 창에서 별도 테스트 실행 진입점을 만듬TDD-Application태스크를 추가해linktrip-application/src/test/kotlin/com/linktrip/application하위 테스트만 실행하도록 구성linktrip-application모듈에applicationTest,applicationTestCoverage태스크를 추가해 application 테스트와 JaCoCo 커버리지 리포트를 분리 실행할 수 있도록 함TDD-Application실행 후 커버리지 HTML 메인 리포트를 자동으로 열도록 구성buildDir사용을layout.buildDirectory기반으로 정리체크리스트
Summary by CodeRabbit
릴리스 노트