Review fixes

Author: KirillSergeevich

.github/workflows/merge-main.yaml

@@ -45,6 +45,9 @@ jobs:
     needs: [linting, build]
     runs-on: ubuntu-latest
     if: always() && needs.linting.result == 'success' && needs.build.result == 'success'
+    permissions:
+      contents: read
+      id-token: write
 
     steps:
       - name: Checkout code
@@ -77,6 +80,6 @@ jobs:
 
       - name: Publish to npm
         if: steps.version-check.outputs.should_publish == 'true'
-        run: npm publish
+        run: npm publish --provenance
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

credentials/LinkedApi.credentials.ts

@@ -8,6 +8,7 @@ import {
 export class LinkedApi implements ICredentialType {
 	name = 'linkedApi';
 	displayName = 'Linked API';
+	icon = 'file:linked-api-light.svg' as const;
 	documentationUrl = 'https://linkedapi.io/integrations/n8n/creating-credential/';
 
 	properties: INodeProperties[] = [

credentials/linked-api-light.svg

@@ -4,7 +4,6 @@ import type {
 	INodeType,
 	INodeTypeDescription,
 } from 'n8n-workflow';
-import { NodeConnectionType, NodeOperationError } from 'n8n-workflow';
 import {
 	availableAdminOperations,
 	availableOtherOperations,
@@ -113,8 +112,8 @@ export class LinkedApi implements INodeType {
 		defaults: {
 			name: 'Linked API',
 		},
-		inputs: [NodeConnectionType.Main],
-		outputs: [NodeConnectionType.Main],
+		inputs: ['main'],
+		outputs: ['main'],
 		usableAsTool: true,
 		hints: [
 			{
@@ -188,18 +187,13 @@ export class LinkedApi implements INodeType {
 
 	async execute(this: IExecuteFunctions): Promise<INodeExecutionData[][]> {
 		const operation = this.getNodeParameter('operation', 0) as string;
-		const credentials = await this.getCredentials('linkedApi');
-
-		if (credentials === undefined) {
-			throw new NodeOperationError(this.getNode(), 'No credentials got returned!');
-		}
 
 		const items = this.getInputData();
 		const returnData: INodeExecutionData[] = [];
 
 		for (let i = 0; i < items.length; i++) {
 			try {
-				const responseData = await operations[operation].execute(this);
+				const responseData = await operations[operation].execute(this, i);
 				if (Array.isArray(responseData)) {
 					for (const entry of responseData) {
 						returnData.push({ json: entry, pairedItem: { item: i } });

nodes/LinkedApi/LinkedApi.node.ts

@@ -41,10 +41,13 @@ export class AdminSetLimits extends AdminLinkedApiOperation {
 			throw new NodeOperationError(
 				context.getNode(),
 				`Invalid JSON format for limits: ${limitsString}`,
+				{ itemIndex: this.itemIndex },
 			);
 		}
 		if (!Array.isArray(limits)) {
-			throw new NodeOperationError(context.getNode(), 'Limits must be a JSON array');
+			throw new NodeOperationError(context.getNode(), 'Limits must be a JSON array', {
+				itemIndex: this.itemIndex,
+			});
 		}
 		return {
 			accountId: this.stringParameter(context, 'accountId'),

nodes/LinkedApi/operations/admin/AdminSetLimits.ts

@@ -28,7 +28,7 @@ export class CommentOnPost extends StandardLinkedApiOperation {
 	];
 
 	public body(context: IExecuteFunctions): Record<string, any> {
-		const additionalParameters = context.getNodeParameter('additionalParameters', 0, {}) as {
+		const additionalParameters = context.getNodeParameter('additionalParameters', this.itemIndex, {}) as {
 			postCompanyUrl?: string;
 		};
 

nodes/LinkedApi/operations/webhook/CommentOnPost.ts

@@ -94,10 +94,10 @@ export class CreatePost extends StandardLinkedApiOperation {
 
 	public body(context: IExecuteFunctions): Record<string, any> {
 		const text = this.stringParameter(context, 'postText');
-		const additionalParameters = context.getNodeParameter('additionalParameters', 0, {}) as {
+		const additionalParameters = context.getNodeParameter('additionalParameters', this.itemIndex, {}) as {
 			postCompanyUrl?: string;
 		};
-		const attachmentsData = context.getNodeParameter('attachments', 0, {}) as {
+		const attachmentsData = context.getNodeParameter('attachments', this.itemIndex, {}) as {
 			attachment?: Array<{ type: string; url: string; name?: string }>;
 		};
 

nodes/LinkedApi/operations/webhook/CreatePost.ts

@@ -49,7 +49,7 @@ export class FetchCompany extends StandardLinkedApiOperation {
 	];
 
 	public body(context: IExecuteFunctions): Record<string, any> {
-		const dataToRetrieve = context.getNodeParameter('dataToRetrieve', 0, []) as string[];
+		const dataToRetrieve = context.getNodeParameter('dataToRetrieve', this.itemIndex, []) as string[];
 		const retrieveEmployees = dataToRetrieve.includes('employees');
 		const retrieveDMs = dataToRetrieve.includes('decisionMakers');
 		const retrievePosts = dataToRetrieve.includes('posts');

nodes/LinkedApi/operations/webhook/FetchCompany.ts

@@ -65,7 +65,7 @@ export class FetchPerson extends StandardLinkedApiOperation {
 		}),
 	];
 	public body(context: IExecuteFunctions): Record<string, any> {
-		const dataToRetrieve = context.getNodeParameter('dataToRetrieve', 0, []) as string[];
+		const dataToRetrieve = context.getNodeParameter('dataToRetrieve', this.itemIndex, []) as string[];
 		const retrieveExperience = dataToRetrieve.includes('experience');
 		const retrieveEducation = dataToRetrieve.includes('education');
 		const retrieveSkills = dataToRetrieve.includes('skills');

nodes/LinkedApi/operations/webhook/FetchPerson.ts

@@ -68,7 +68,7 @@ export class FetchPost extends StandardLinkedApiOperation {
 	];
 
 	public body(context: IExecuteFunctions): Record<string, any> {
-		const dataToRetrieve = context.getNodeParameter('dataToRetrieve', 0, []) as string[];
+		const dataToRetrieve = context.getNodeParameter('dataToRetrieve', this.itemIndex, []) as string[];
 		const retrieveComments = dataToRetrieve.includes('comments');
 		const retrieveReactions = dataToRetrieve.includes('reactions');