From c8b60a52312195d2d1bd3f8698c1e39f448cb116 Mon Sep 17 00:00:00 2001 From: nilampp Date: Fri, 17 Oct 2025 12:12:27 -0700 Subject: [PATCH 1/7] initial commit --- main.tf | 2 +- outputs.tf | 12 ++++++------ variables.tf | 9 +++++---- 3 files changed, 12 insertions(+), 11 deletions(-) diff --git a/main.tf b/main.tf index 9b32ce06bb..0bfc354510 100644 --- a/main.tf +++ b/main.tf @@ -16,7 +16,7 @@ data "aws_ami" "app_ami" { resource "aws_instance" "web" { ami = data.aws_ami.app_ami.id - instance_type = "t3.nano" + instance_type = var.instance_type tags = { Name = "HelloWorld" diff --git a/outputs.tf b/outputs.tf index b35171bef1..c429b19b48 100644 --- a/outputs.tf +++ b/outputs.tf @@ -1,7 +1,7 @@ -#output "instance_ami" { -# value = aws_instance.web.ami -#} +output "instance_ami" { + value = aws_instance.web.ami +} -#output "instance_arn" { -# value = aws_instance.web.arn -#} +output "instance_arn" { + value = aws_instance.web.arn +} diff --git a/variables.tf b/variables.tf index c750667e0f..559992c18a 100644 --- a/variables.tf +++ b/variables.tf @@ -1,4 +1,5 @@ -#variable "instance_type" { -# description = "Type of EC2 instance to provision" -# default = "t3.nano" -#} +variable "instance_type" +{ + description = "Type of EC2 instance to provision" + default = "t3.nano" +} From 735f7f42b9cfdcb7ed5dd28d86aa2fb7fa6b7499 Mon Sep 17 00:00:00 2001 From: nilampp Date: Fri, 17 Oct 2025 15:10:00 -0700 Subject: [PATCH 2/7] Update variables.tf --- variables.tf | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/variables.tf b/variables.tf index 559992c18a..60856bc925 100644 --- a/variables.tf +++ b/variables.tf @@ -1,5 +1,4 @@ -variable "instance_type" -{ +variable "instance_type" { description = "Type of EC2 instance to provision" default = "t3.nano" } From 44cad23480c2361c7adc9ec115159dd355a90ad8 Mon Sep 17 00:00:00 2001 From: nilampp Date: Thu, 23 Oct 2025 12:33:35 -0700 Subject: [PATCH 3/7] creating security group --- main.tf | 36 ++++++++++++++++++++++++++++++++++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/main.tf b/main.tf index 0bfc354510..c24320b60b 100644 --- a/main.tf +++ b/main.tf @@ -14,11 +14,43 @@ data "aws_ami" "app_ami" { owners = ["979382823631"] # Bitnami } +data "aws_vpc" "default"{ + default = true +} + resource "aws_instance" "web" { ami = data.aws_ami.app_ami.id - instance_type = var.instance_type + instance_type = "t3.nano" + +vpc_security_group_ids = [aws_security_group.security_group.id] tags = { - Name = "HelloWorld" + Name = "Learning Terraform" } } + +resource "aws_security_group" "security_group"{ + name = "security_group" + description = "Allow HTTP and HTTPS in. Allow everything out" + vpc_id = data.aws_vpc.default.id +} + +resource "aws_security_group_rule" "rule_http_in"{ + type = "ingress" + from_port = 443 + to_port = 443 + protocol = "tcp" + cidr-blocks = ["0.0.0.0/0"] + + security_group_id = aws_security_group.security_group.id +} + +resource "aws_security_group_rule" "rule_http_everything_out"{ + type = "egress" + from_port = 0 + to_port = 0 + protocol = "-1" + cidr-blocks = ["0.0.0.0/0"] + + security_group_id = aws_security_group.security_group.id +} \ No newline at end of file From f90693b541040e267114ec56dfde18e8f41cd778 Mon Sep 17 00:00:00 2001 From: nilampp Date: Thu, 23 Oct 2025 12:36:01 -0700 Subject: [PATCH 4/7] fixing the syntax --- main.tf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/main.tf b/main.tf index c24320b60b..653fdc54e4 100644 --- a/main.tf +++ b/main.tf @@ -40,7 +40,7 @@ resource "aws_security_group_rule" "rule_http_in"{ from_port = 443 to_port = 443 protocol = "tcp" - cidr-blocks = ["0.0.0.0/0"] + cidr_blocks = ["0.0.0.0/0"] security_group_id = aws_security_group.security_group.id } @@ -50,7 +50,7 @@ resource "aws_security_group_rule" "rule_http_everything_out"{ from_port = 0 to_port = 0 protocol = "-1" - cidr-blocks = ["0.0.0.0/0"] + cidr_blocks = ["0.0.0.0/0"] security_group_id = aws_security_group.security_group.id } \ No newline at end of file From cbf8d0370e30f06b60d87a27829c09379835423f Mon Sep 17 00:00:00 2001 From: nilampp Date: Thu, 23 Oct 2025 15:33:51 -0700 Subject: [PATCH 5/7] use module for security. group --- main.tf | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/main.tf b/main.tf index 653fdc54e4..aa06a79aa5 100644 --- a/main.tf +++ b/main.tf @@ -22,13 +22,27 @@ resource "aws_instance" "web" { ami = data.aws_ami.app_ami.id instance_type = "t3.nano" -vpc_security_group_ids = [aws_security_group.security_group.id] + vpc_security_group_ids = [module.module_security_group.security_group_id] tags = { Name = "Learning Terraform" } } +module "module_security-group" { + source = "terraform-aws-modules/security-group/aws" + version = "5.3.1" + name = "module_security-group" + + vpc_id = data.aws_vpc.default.id + + ingress_rules = ["http-80-tcp", "https-443-tcp"] + ingress_cidr_blocks = [0.0.0.0/0] + + egress_rules = ["all-all"] + egress_cidr_blocks = [0.0.0.0/0] +} + resource "aws_security_group" "security_group"{ name = "security_group" description = "Allow HTTP and HTTPS in. Allow everything out" From 57de1611cd8a3ab710d070709f5ff2a6918de68b Mon Sep 17 00:00:00 2001 From: nilampp Date: Thu, 23 Oct 2025 15:37:37 -0700 Subject: [PATCH 6/7] revert module changes --- main.tf | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/main.tf b/main.tf index aa06a79aa5..d415fc77a5 100644 --- a/main.tf +++ b/main.tf @@ -22,27 +22,13 @@ resource "aws_instance" "web" { ami = data.aws_ami.app_ami.id instance_type = "t3.nano" - vpc_security_group_ids = [module.module_security_group.security_group_id] + vpc_security_group_ids = [aws_security_group.security_group_id] tags = { Name = "Learning Terraform" } } -module "module_security-group" { - source = "terraform-aws-modules/security-group/aws" - version = "5.3.1" - name = "module_security-group" - - vpc_id = data.aws_vpc.default.id - - ingress_rules = ["http-80-tcp", "https-443-tcp"] - ingress_cidr_blocks = [0.0.0.0/0] - - egress_rules = ["all-all"] - egress_cidr_blocks = [0.0.0.0/0] -} - resource "aws_security_group" "security_group"{ name = "security_group" description = "Allow HTTP and HTTPS in. Allow everything out" From bace392514f0ffe80f96405ad996d0f499b1e30b Mon Sep 17 00:00:00 2001 From: nilampp Date: Thu, 23 Oct 2025 15:50:51 -0700 Subject: [PATCH 7/7] fix vpc_securitygroup --- main.tf | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/main.tf b/main.tf index d415fc77a5..7139c1a0fe 100644 --- a/main.tf +++ b/main.tf @@ -18,19 +18,19 @@ data "aws_vpc" "default"{ default = true } -resource "aws_instance" "web" { +resource "aws_instance" "blog" { ami = data.aws_ami.app_ami.id instance_type = "t3.nano" - vpc_security_group_ids = [aws_security_group.security_group_id] + vpc_security_group_ids = [aws_security_group.blog.id] tags = { Name = "Learning Terraform" } } -resource "aws_security_group" "security_group"{ - name = "security_group" +resource "aws_security_group" "blog"{ + name = "blog" description = "Allow HTTP and HTTPS in. Allow everything out" vpc_id = data.aws_vpc.default.id }