Update CI workflow#135
Merged
rubensworks merged 2 commits intoLinkedSoftwareDependencies:masterfrom Mar 20, 2025
surilindur:chore/update-ci
Merged
Update CI workflow#135rubensworks merged 2 commits intoLinkedSoftwareDependencies:masterfrom surilindur:chore/update-ci
rubensworks merged 2 commits intoLinkedSoftwareDependencies:masterfrom
surilindur:chore/update-ci
Conversation
rubensworks
reviewed
Mar 19, 2025
| with: | ||
| path: '**/node_modules' | ||
| key: ${{ runner.os }}-test-modules-${{ hashFiles('**/yarn.lock') }} | ||
| path: .yarn |
Member
There was a problem hiding this comment.
Why not cache node_modules anymore?
Contributor
Author
There was a problem hiding this comment.
Because the linking step (to unpack the downloaded packages into node_modules) is faster than the download step, so it is more efficient to cache the download cache of Yarn (located in .yarn). That way, Yarn can skip the download step, which is most expensive, and proceed to just comparing its local cache against the server versions, and then do unpacking.
Member
There was a problem hiding this comment.
But if we just cache node_modules, we don't have to 1) download, and 2) link. So it's more efficient to cache that, right?
Contributor
Author
There was a problem hiding this comment.
I changed it back to caching node_modules instead.
rubensworks
merged commit 34b297c
into
LinkedSoftwareDependencies:master
21 checks passed
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small set of changes to bump the actions versions, and to add better names to some of the steps:
.yarnfolder because that is the main one needed for Yarn version 4.--immutableflag to detect any lockfile inconsistencies in the CI.