Update @rubensworks/eslint-config from 1.0.1 to 1.2.0 (#159)

Agent-Logs-Url: https://github.com/LinkedSoftwareDependencies/Components.js/sessions/3a1755d4-cde4-46b9-888f-a2c602d2fd9a

Co-authored-by: rubensworks <440384+rubensworks@users.noreply.github.com>

Author: Copilot

lib/construction/strategy/ConstructionStrategyCommonJs.ts

@@ -57,7 +57,7 @@ export class ConstructionStrategyCommonJs implements IConstructionStrategy<any>
       if (typeof object !== 'function') {
         throw new Error(`Attempted to construct ${options.requireElement} from module ${options.requireName} that does not have a constructor`);
       }
-      object = new (Function.prototype.bind.apply(object, <[any, ...any]>[{}].concat(options.args)))();
+      object = new (Function.prototype.bind.apply(object, <[any, ...any]>[{}, ...options.args ]))();
     }
 
     return object;
@@ -72,25 +72,22 @@ export class ConstructionStrategyCommonJs implements IConstructionStrategy<any>
    */
   public requireCurrentRunningModuleIfCurrent(moduleState: IModuleState, requireName: string): { value: any } | false {
     const pckg = moduleState.packageJsons[moduleState.mainModulePath];
-    if (pckg) {
-      if (requireName === pckg.name) {
-        const mainPath: string = Path.posix.join(moduleState.mainModulePath, pckg.main);
-        const required = this.req(mainPath);
-        if (required) {
-          return { value: required };
-        }
+    if (pckg && requireName === pckg.name) {
+      const mainPath: string = Path.posix.join(moduleState.mainModulePath, pckg.main);
+      const required = this.req(mainPath);
+      if (required) {
+        return { value: required };
       }
     }
     return false;
   }
 
   public createHash(options: ICreationStrategyHashOptions<any>): any {
-    return options.entries.reduce((data: Record<string, any>, entry: { key: string; value: any } | undefined) => {
-      if (entry) {
-        data[entry.key] = entry.value;
-      }
-      return data;
-    }, {});
+    return Object.fromEntries(
+      options.entries
+        .filter((entry): entry is { key: string; value: any } => entry !== undefined)
+        .map(entry => [ entry.key, entry.value ]),
+    );
   }
 
   public createArray(options: ICreationStrategyArrayOptions<any>): any {

lib/construction/strategy/ConstructionStrategyCommonJsString.ts

@@ -54,7 +54,7 @@ export class ConstructionStrategyCommonJsString implements IConstructionStrategy
         this.getCurrentRunningModuleMain(options.moduleState),
       )}` :
       options.requireName;
-    let serialization = `require('${resultingRequirePath.replace(/\\/gu, '/')}')`;
+    let serialization = `require('${resultingRequirePath.replaceAll('\\', '/')}')`;
 
     // Determine the child of the require'd element
     if (options.requireElement) {

lib/loading/ComponentRegistry.ts

@@ -37,7 +37,7 @@ export class ComponentRegistry {
    */
   public async registerAvailableModules(): Promise<void> {
     await Promise.all(Object.values(this.moduleState.componentModules)
-      .flatMap(Object.values)
+      .flatMap(x => Object.values(x))
       .map((moduleResourceUrl: string) => this.registerModule(moduleResourceUrl)));
   }
 

lib/preprocess/ConfigPreprocessorComponent.ts

@@ -289,10 +289,8 @@ export class ConfigPreprocessorComponent implements IConfigPreprocessor<ICompone
     // Emit warning on undefined parameters inside the component's scope
     const prefix = handleResponse.component.value;
     for (const property of Object.keys(config.property)) {
-      if (property.startsWith(prefix)) {
-        if (!validParameters[property]) {
-          this.logger.warn(`Detected potentially invalid component parameter '${property}' in a config`);
-        }
+      if (property.startsWith(prefix) && !validParameters[property]) {
+        this.logger.warn(`Detected potentially invalid component parameter '${property}' in a config`);
       }
     }
   }

lib/preprocess/ConfigPreprocessorOverride.ts

@@ -148,7 +148,7 @@ export class ConfigPreprocessorOverride implements IConfigPreprocessor<Resource[
     while (change) {
       change = false;
       for (const [ id, chain ] of Object.entries(overrideChains)) {
-        let next = chain[chain.length - 1];
+        let next = chain.at(-1)!;
         // If the next part of the chain is found in `overrideChains` we can merge them and remove the tail entry
         while (overrideChains[next.value]) {
           change = true;
@@ -158,7 +158,7 @@ export class ConfigPreprocessorOverride implements IConfigPreprocessor<Resource[
           // In case of a cycle there will be a point where next equals the first element,
           // at which point it will delete itself.
           delete overrideChains[next.value];
-          next = chain[chain.length - 1];
+          next = chain.at(-1)!;
         }
         // Reset the loop since we are modifying the object we are iterating over
         if (change) {
@@ -175,7 +175,7 @@ export class ConfigPreprocessorOverride implements IConfigPreprocessor<Resource[
    * @param chains - The override chains to check.
    */
   protected validateChains(chains: Resource[][]): void {
-    const targets = chains.map((chain): string => chain[chain.length - 1].value);
+    const targets = chains.map((chain): string => chain.at(-1)!.value);
     for (let i = 0; i < targets.length; ++i) {
       const duplicateIdx = targets.findIndex((target, idx): boolean => idx > i && target === targets[i]);
       if (duplicateIdx > 0) {
@@ -231,18 +231,18 @@ export class ConfigPreprocessorOverride implements IConfigPreprocessor<Resource[
    * @param chain - The chain to find the target of.
    */
   protected getChainTarget(chain: Resource[]): Resource {
-    const target = chain[chain.length - 1];
+    const target = chain.at(-1)!;
     const types = uniqueTypes(target, this.componentResources);
     if (!types || types.length === 0) {
-      throw new ErrorResourcesContext(`Missing type for override target ${target.value} of Override ${chain[chain.length - 2].value}`, {
+      throw new ErrorResourcesContext(`Missing type for override target ${target.value} of Override ${chain.at(-2)!.value}`, {
         target,
-        override: chain[chain.length - 2],
+        override: chain.at(-2),
       });
     }
     if (types.length > 1) {
-      throw new ErrorResourcesContext(`Found multiple types for override target ${target.value} of Override ${chain[chain.length - 2].value}`, {
+      throw new ErrorResourcesContext(`Found multiple types for override target ${target.value} of Override ${chain.at(-2)!.value}`, {
         target,
-        override: chain[chain.length - 2],
+        override: chain.at(-2),
       });
     }
     return target;

lib/preprocess/ParameterHandler.ts

@@ -53,7 +53,7 @@ export class ParameterHandler {
         });
       }
       value = this.objectLoader.createCompactedResource({
-        list: values.flatMap(subValue => <Resource[]> subValue.list),
+        list: values.flatMap(subValue => subValue.list!),
       });
     }
 

lib/preprocess/constructorargumentsmapping/ConstructorArgumentsElementMappingHandlerList.ts

@@ -26,7 +26,7 @@ export class ConstructorArgumentsElementMappingHandlerList implements IConstruct
     // Recursively handle all field values.
     const ret = mapper.objectLoader.createCompactedResource({});
     ret.list = [];
-    for (const argument of (<Resource[]> constructorArgs.list)) {
+    for (const argument of constructorArgs.list!) {
       if (argument.property.fields || argument.property.elements) {
         ret.list.push(mapper
           .applyConstructorArgumentsParameters(configRoot, argument, configElement, genericsContext));

lib/preprocess/overridesteps/OverrideUtil.ts

@@ -12,7 +12,7 @@ export type OverrideStepFieldName = `${typeof OVERRIDE_STEP_FIELD_NAMES[number]}
  * @param step - Override step to get the fields from.
  * @param expected - For each field, how many are expected. The value can be undefined if there is no fixed amount.
  */
-export function extractOverrideStepFields(step: Resource, expected: { [key in OverrideStepFieldName]?: number } = {}):
+export function extractOverrideStepFields(step: Resource, expected: {[key in OverrideStepFieldName]?: number } = {}):
 Record<OverrideStepFieldName, Resource[]> {
   // Type is not correct yet now but will be completed in the loop below
   const result = <Record<OverrideStepFieldName, Resource[]>> {};
@@ -57,7 +57,8 @@ export function getPropertyResourceList(config: Resource, parameter: Resource):
 
   // Having multiple lists can happen if multiple config files add elements to the same list
   const list = properties.flatMap(prop => prop.list);
-  if (list.some(res => res === undefined)) {
+  // eslint-disable-next-line unicorn/no-useless-undefined
+  if (list.includes(undefined)) {
     throw new ErrorResourcesContext(`Invalid target in Override step targeting ${config.value}: ${parameter.value} does not reference a list`, {
       config,
     });

lib/rdf/RdfStreamIncluder.ts

@@ -100,6 +100,6 @@ export class RdfStreamIncluder extends Transform {
    * @param iri A potential IRI.
    */
   public static isValidIri(iri: string): boolean {
-    return Boolean(/:((\/\/)|(.*:))/u.exec(iri));
+    return Boolean(/:((\/\/)|(.*:))/u.test(iri));
   }
 }

lib/util/ErrorResourcesContext.ts

@@ -57,7 +57,6 @@ export class ErrorResourcesContext extends Error {
   }
 }
 
-// eslint-disable-next-line @typescript-eslint/consistent-indexed-object-style
 export interface IErrorContext {
   [key: string]: Resource | Resource[] | string | undefined | IErrorContext | IParamValueConflict;
 }