LKE-14973: Remove custom actions management (#39)

Revert "LKE-14893: Restore custom actions handling (#38)"

This reverts commit 09f43bd.

Author: gmasclet

README.md

@@ -3,7 +3,7 @@
 ## Purpose and principles
 The plugin is used to import Third-Party Data to enrich some nodes in your graph:
 - For example, you may have a `Company` node in your graph, and you want to enrich it with data from the [French Official Company Information API](https://annuaire-entreprises.data.gouv.fr/).
-- You click any `Company` node in the graph, use the `custom action` menu and click `Fetch details for French Company`.
+- You click any `Company` node in the graph, use the `Plugins` menu and click `Fetch details for French Company`.
 - The plugin opens and shows a list of matching results from the French Company Information API.
 - You select the result you want to import, which creates a new `Person_Details` node in the graph with the data from the API, linked to the original `Person` node.
 

packages/frontend/src/api/api.ts

@@ -1,5 +1,4 @@
 import {RestClient} from '@linkurious/rest-client';
-import {CustomAction} from '@linkurious/rest-client/dist/src/api/CustomAction/types';
 
 import {
   ApiResponse,
@@ -8,10 +7,7 @@ import {
 } from '../../../shared/api/response';
 import {MyPluginConfig, MyPluginConfigPublic} from '../../../shared/myPluginConfig';
 import {STRINGS} from '../../../shared/strings';
-import {
-  IntegrationModel,
-  IntegrationModelPublic
-} from '../../../shared/integration/IntegrationModel.ts';
+import {IntegrationModelPublic} from '../../../shared/integration/IntegrationModel.ts';
 
 function getBaseUrl(relativeUrl: string): string {
   return new URL(relativeUrl, document.baseURI).toString();
@@ -128,16 +124,6 @@ export class API {
     }
   }
 
-  async getCustomActions(integration: IntegrationModel): Promise<CustomAction[]> {
-    const actionsR = await this.server.customAction.getCustomActions({
-      sourceKey: integration.sourceKey
-    });
-    if (!actionsR.isSuccess()) {
-      throw new Error(STRINGS.errors.customActions.loadFailed(actionsR.body));
-    }
-    return actionsR.body.filter((a) => a.urlTemplate.includes(`integrationId=${integration.id}`));
-  }
-
   async updatePluginConfig(config: MyPluginConfig): Promise<void> {
     await this.plugin('./api/admin-config', {}, 201, STRINGS.errors.setAdminConfig, config);
   }

packages/frontend/src/dev/apiMocks.ts

@@ -1,4 +1,4 @@
-import {User, CustomAction} from '@linkurious/rest-client';
+import {User} from '@linkurious/rest-client';
 
 import {
   IntegrationModel,
@@ -264,36 +264,5 @@ export const API_MOCKS: ApiMock[] = [
         ]
       }
     }
-  },
-  // lit custom actions for valid data-source
-  {
-    match: `/api/${validSourceKey}/customAction`,
-    response: {
-      body: [
-        {
-          id: 1,
-          name: 'fetch person info from DnB',
-          description: 'fetch person info from DnB yeah and some details too',
-          sourceKey: validSourceKey,
-          urlTemplate: `{{baseURL}}plugin/3d/?integrationId=${defaultIntegrationId}&nodeId={{node}}&sourceKey={{sourceKey}}&noise=1234356743245678543234567865432134567865432`
-        },
-        {
-          id: 2,
-          name: 'other action',
-          description: 'this action is unrelated to this plugin',
-          sourceKey: validSourceKey,
-          urlTemplate: `{{baseURL}}plugin/image-export/?viz={{visualization}}&sourceKey={{sourceKey}}`
-        }
-      ] as CustomAction[]
-    }
-  },
-  // create custom action
-  {
-    verb: 'POST',
-    match: `/api/${validSourceKey}/customAction`,
-    response: {
-      body: {},
-      status: 201
-    }
   }
 ];

packages/frontend/src/serviceFacade.ts

@@ -1,7 +1,7 @@
 import {LkEdge, LkNode, LkError, Response, User} from '@linkurious/rest-client';
 
 import {VendorResult} from '../../shared/api/response';
-import {IntegrationModel, IntegrationModelPublic} from '../../shared/integration/IntegrationModel';
+import {IntegrationModelPublic} from '../../shared/integration/IntegrationModel';
 import {VendorIntegrationPublic} from '../../shared/integration/vendorIntegrationPublic';
 import {asError, clone, randomString} from '../../shared/utils';
 import {STRINGS} from '../../shared/strings';
@@ -99,7 +99,7 @@ export class ServiceFacade {
       await this.config.saveNewIntegration(newIntegration);
       p.update(STRINGS.ui.global.done);
     });
-    await this.ui.showConfirmIntegrationCreated(newIntegration);
+    await this.ui.showConfirmIntegrationCreated();
   }
 
   async editIntegration(integrationId: string): Promise<void> {
@@ -229,17 +229,6 @@ export class ServiceFacade {
     }
   }
 
-  async createCustomAction(
-    integration: IntegrationModel,
-    backTo: 'integration-list'
-  ): Promise<void> {
-    console.log('CREATE_CUSTOM_ACTION: ' + JSON.stringify(integration));
-    await this.ui.showCustomActionManager(integration);
-    if (backTo === 'integration-list') {
-      await this.ui.showIntegrationsList();
-    }
-  }
-
   async deleteIntegration(integrationId: string): Promise<void> {
     await this.ui.longTask.run(async (p) => {
       p.update(STRINGS.ui.editIntegration.deletingIntegration);

packages/frontend/src/ui/edition/customActionManager.ts

@@ -53,13 +53,6 @@ export class IntegrationList extends BaseUI {
             this.ui.button.create(STRINGS.ui.integrationList.editButton, {small: true}, () =>
               this.services.editIntegration(int.id)
             ),
-            this.ui.button.create(
-              STRINGS.ui.integrationList.installButton,
-              {small: true, outline: true},
-              () => {
-                return this.services.createCustomAction(int, 'integration-list');
-              }
-            ),
             this.ui.button.create(
               STRINGS.ui.integrationList.deleteButton,
               {type: 'danger', outline: true, small: true},

packages/frontend/src/ui/integrationList.ts

@@ -13,7 +13,6 @@ import {IntegrationList} from './integrationList';
 import {IntegrationEditor} from './integrationEditor';
 import {Button} from './button';
 import {SearchResults} from './searchResults';
-import {CustomActionManager} from './edition/customActionManager';
 
 export class UiFacade {
   private readonly services: ServiceFacade;
@@ -79,11 +78,6 @@ export class UiFacade {
     await integrationList.show();
   }
 
-  async showCustomActionManager(integration: IntegrationModel): Promise<void> {
-    const cam = new CustomActionManager(this.services);
-    await cam.show(integration);
-  }
-
   async showEmptyState(): Promise<void> {
     this.showContent(
       $elem('div', {class: 'alert alert-primary', role: 'alert'}, [
@@ -93,20 +87,13 @@ export class UiFacade {
     );
   }
 
-  async showConfirmIntegrationCreated(newIntegration: IntegrationModel): Promise<void> {
+  async showConfirmIntegrationCreated(): Promise<void> {
     await this.popIn.showElement(
       STRINGS.ui.integrationCreated.title,
       $elem('p', {}, STRINGS.ui.integrationCreated.message),
       [
-        this.button.create(
-          STRINGS.ui.integrationCreated.dontCreateCustomActionButton,
-          {type: 'secondary'},
-          () => this.popIn.close()
-        ),
-        this.button.create(
-          STRINGS.ui.integrationCreated.createCustomActionButton,
-          {},
-          async () => await this.showCustomActionManager(newIntegration)
+        this.button.create(STRINGS.ui.integrationCreated.confirmModalCloseButton, {}, () =>
+          this.popIn.close()
         )
       ]
     );

packages/frontend/src/ui/uiFacade.ts

@@ -1,10 +1,4 @@
-import {
-  ICreateNodeParams,
-  ICreateEdgeParams,
-  ICreateCustomActionParams,
-  SharingMode,
-  LkNode
-} from '@linkurious/rest-client';
+import {ICreateNodeParams, ICreateEdgeParams, LkNode} from '@linkurious/rest-client';
 
 import {PluginAction} from '../../backend/src/server/api';
 import {NeighborResult, VendorResult} from '../api/response';
@@ -165,21 +159,6 @@ export class VendorIntegrationPublic<VI extends IntegrationModelPublic = Integra
     return inputValue;
   }
 
-  getCustomAction(basePath: string): ICreateCustomActionParams {
-    return {
-      sourceKey: this.model.sourceKey,
-      name: STRINGS.customAction.name(this.vendor),
-      description: STRINGS.customAction.details(this.vendor),
-      urlTemplate: `{{baseURL}}plugins/${basePath}/?action=search&integrationId=${
-        this.model.id
-      }&sourceKey=${this.model.sourceKey}&nodeId={{node:${JSON.stringify(
-        this.model.inputNodeCategory
-      )}}}#linkurious-modal`,
-      sharing: SharingMode.SOURCE,
-      sharedWithGroups: undefined
-    };
-  }
-
   getPluginAction(): PluginAction {
     return {
       sourceKey: this.model.sourceKey,

packages/shared/integration/vendorIntegrationPublic.ts

@@ -11,7 +11,7 @@ import {GraphItemSchema, GraphPropertySchema} from '../api/response';
 import {VendorIntegration} from '../integration/vendorIntegration';
 
 export const STRINGS = {
-  emptyStatePrefix: `To use this plugin, please set up an integration and run it via a Custom Action. For details, please check the `,
+  emptyStatePrefix: `To use this plugin, please set up an integration. For details, please check the `,
   emptyStateLinkText: 'online documentation',
   emptyStateLinkUrl: 'https://github.com/Linkurious/lke-plugin-third-party-data#readme',
   errors: {
@@ -98,10 +98,6 @@ export const STRINGS = {
     getAdminConfig: `Could not get the plugin's admin-configuration`,
     setAdminConfig: `Could not update the plugin's admin-configuration`,
     getUserConfig: `Could not get the plugin's user-configuration`,
-    customActions: {
-      loadFailed: (error: LkError): string => `Failed to get custom actions: ${error.message}`,
-      deleteFailed: (error: LkError): string => `Failed to delete custom action: ${error.message}`
-    },
     multiSelector: {
       listUndefined: 'Unexpected error: list is empty'
     },
@@ -131,11 +127,6 @@ export const STRINGS = {
     integrationNotFound: (integrationId: string): string =>
       `Integration ${integrationId} was not found`
   },
-  customAction: {
-    name: (vendor: Vendor): string => `Fetch details from ${vendor.name}`,
-    details: (vendor: Vendor): string =>
-      `Get details from ${vendor.name} (action auto-generated by the third-party data plugin)`
-  },
   pluginAction: {
     name: (vendor: Vendor): string => `Fetch details from ${vendor.name}`
   },
@@ -144,16 +135,6 @@ export const STRINGS = {
       constant: `Fixed value`,
       actionColumnHead: 'Action'
     },
-    customActionManager: {
-      title: 'Manage custom actions for this integration',
-      description: `Custom actions are used to launch an integration from a node context-menu`,
-      deleteButton: 'Delete',
-      noCustomActions: `No custom action found for this integration, you can create one using the button bellow.`,
-      addActionDescription: 'This will create a new custom action, shared at the data-source level',
-      addButton: 'Add custom action',
-      listTitle: (actions: number): string =>
-        `Found ${actions} custom action(s) for this integration:`
-    },
     global: {
       closeButton: 'Close',
       noValue: '(No value)',
@@ -204,7 +185,6 @@ export const STRINGS = {
       title: 'Integrations list',
       actionsHeader: 'Actions',
       editButton: 'Edit',
-      installButton: 'Install',
       deleteButton: 'Delete',
       addButton: 'Add integration',
       vendorHeader: 'Vendor API',
@@ -238,9 +218,8 @@ export const STRINGS = {
     },
     integrationCreated: {
       title: 'Integration created successfully',
-      message: `The new integration was successfully saved. You can install this integration by adding a custom action to launch it from a node's context menu.`,
-      createCustomActionButton: 'Install integration',
-      dontCreateCustomActionButton: 'Later'
+      message: 'The new integration was successfully saved.',
+      confirmModalCloseButton: 'Close'
     }
   }
 };