Merge pull request #1575 from smoe/cppcheck_fixes

int (also literals as it seems) are signed by default

Author: jepler

src/emc/usr_intf/emcsched.cc

@@ -190,7 +190,7 @@ void SchedEntry::setTool(int t) {
 
 static void crcInit() {
   crc rmdr;
-  int i;
+  unsigned int i;
   uint32_t bit;
 
   for (i = 0; i < 256; ++i)

src/hal/drivers/hal_gm.c

@@ -1126,18 +1126,18 @@ read(void *arg, long period)
 {
     	gm_device_t	*device = (gm_device_t *)arg;
     	card	*pCard = device->pCard;
-    	int		i;
+	unsigned int i;
 	hal_u32_t temp;
-	
+
       //basic card functionality: watchdog, switches, estop
 	card_mgr(arg, period);
 
       //read parallel IOs
 	temp=pCard->gpio;
     	for(i = 0; i < 32; i++)
 	{
-		*(device->gpio[i].in) = (hal_bit_t)((temp & (0x0001 << i)) == 0 ? 0 : 1);
-		*(device->gpio[i].inNot) = (hal_bit_t)((temp & (0x0001 << i)) == 0 ? 1 : 0);
+		*(device->gpio[i].in) = (hal_bit_t)((temp & ((unsigned int) 1 << i)) == 0 ? 0 : 1);
+		*(device->gpio[i].inNot) = (hal_bit_t)((temp & ((unsigned int) 1 << i)) == 0 ? 1 : 0);
 	}
 
       //Read Encoders

src/hal/drivers/opto_ac5.c

@@ -401,7 +401,8 @@ Device_DigitalOutWrite(void *arg, long period)
 {
     board_data_t			*pboard = (board_data_t *)arg;
     DigitalPinsParams			*pDigital;
-    int					i, j, portnum=0;
+    int					portnum=0;
+    unsigned int			i,j;
     unsigned long			pins, offset=DATA_WRITE_OFFSET_0,mask;
 
     // For each port.
@@ -421,22 +422,22 @@ Device_DigitalOutWrite(void *arg, long period)
 				       ( *(pDigital->pValue) &&  (pDigital->invert) ))
 					 {	pins |= mask;	    }
 				}
-	   			 mask <<=1; // shift mask
+	   			mask <<=1; // shift mask
 
 			}
 
 			// CHECK LED PINS
 			pDigital = &pboard->port[portnum].io[23];//one before what we want to check
-			for (i = 0;i < 2;i++)
-				{
-			 		mask=1<<(31-i);
-					pDigital++;
+			for (i = 0; i < 2; i++)
+			{
+				mask = (unsigned int) 1 << (31-i);
+				pDigital++;
 
-					if ( *(pDigital->pValue) ==0 ) {	pins |= mask;	    }	
-				}
+				if ( *(pDigital->pValue) == 0 ) {	pins |= mask;	    }	
+			}
 			// Write digital I/O register.
 			writel(pins,pboard->base + (offset));
-			portnum ++;
+			portnum++;
 			offset=DATA_WRITE_OFFSET_1; // set to port1 offset
    		 }
 }