Commit 6695f11
committed
qtvcp: fix undefined name in gcode_editor Qsci import fallback
The PyQt5 branch of the QScintilla import fallback caught ImportError
without binding it (no 'as e') but then passed exc_info=e to LOG.critical,
raising NameError. Because sys.excepthook is installed at qtvcp startup and
pops a modal error dialog, that NameError turns a missing python3-pyqt5.qsci
into an indefinite hang (the dialog blocks forever under headless/CI) instead
of a clean exit.
Bind the exception as e and sys.exit(1), matching the PyQt6 branch below.1 parent 77e9f58 commit 6695f11
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
| 67 | + | |
67 | 68 | | |
68 | 69 | | |
69 | 70 | | |
| |||
0 commit comments