Skip to content

ui-smoke: never sudo in crash capture#4146

Open
grandixximo wants to merge 1 commit into
LinuxCNC:masterfrom
grandixximo:fix-ui-smoke-sudo
Open

ui-smoke: never sudo in crash capture#4146
grandixximo wants to merge 1 commit into
LinuxCNC:masterfrom
grandixximo:fix-ui-smoke-sudo

Conversation

@grandixximo

Copy link
Copy Markdown
Contributor

The ui-smoke crash-capture helper (crashdump_arm) ran sudo sysctl
to set kernel.core_pattern, assuming passwordless sudo on CI. On a
local run without passwordless sudo, sudo prompts for a password on the
TTY and stalls the entire test suite until the user sends a keyboard
interrupt, as reported in #4143.

This drops sudo entirely: core_pattern is set (and gdb installed) only
when the suite already runs as root. Non-root runs skip it and fall
back to a cwd core, so the tests run unattended on every host.

Fixes #4143

Note: CI is expected to fail here for an unrelated reason. Debian sid
is currently broken, not this change.

crashdump_arm ran `sudo sysctl` to set kernel.core_pattern, assuming
passwordless sudo on CI. On a local run without it, sudo prompts for a
password and stalls the whole suite until interrupted. Only adjust
core_pattern (and apt-get gdb) when already root; non-root falls back
to a cwd core. The tests now run unattended everywhere.

Fixes LinuxCNC#4143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test ui-smoke tries to sudo and fails on OK

1 participant