Skip to content

Commit 8f71c22

Browse files
committed
Fix socket URL auto-fill for extension stores
Added handleStore() calls in GetStores and getLoaderByStoreName to automatically fill empty socket URLs using GetExtensionSocketPath(). This ensures stores loaded from config file get correct socket paths without hardcoding user-specific paths, making the configuration portable across different users and systems. Fixes issue where AI extension showed "Not Ready" status due to outdated socket path in stores.yaml configuration.
1 parent b974c0a commit 8f71c22

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

pkg/server/remote_server.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1225,6 +1225,9 @@ func (s *server) GetStores(ctx context.Context, in *SimpleQuery) (reply *Stores,
12251225
wg := sync.WaitGroup{}
12261226
mu := sync.Mutex{}
12271227
for _, item := range stores {
1228+
// Auto-fill socket URL if empty
1229+
handleStore(&item)
1230+
12281231
skip := false
12291232
for _, kind := range kinds.Data {
12301233
if in != nil && in.Kind != "" && !slices.Contains(kind.Categories, in.Kind) {
@@ -1670,6 +1673,8 @@ func (s *server) getLoaderByStoreName(storeName string) (loader testing.Writer,
16701673
var store *testing.Store
16711674
store, err = testing.NewStoreFactory(s.configDir).GetStore(storeName)
16721675
if err == nil && store != nil {
1676+
// Auto-fill socket URL if empty
1677+
handleStore(store)
16731678
loader, err = s.storeWriterFactory.NewInstance(*store)
16741679
if err != nil {
16751680
err = fmt.Errorf("failed to new grpc loader from store %s, err: %v", store.Name, err)

0 commit comments

Comments
 (0)