fix(roles/icingaweb2_module_vspheredb): use canonical archive/refs/tags URL for the module tarball

Author: danyalberchtoldlf

CHANGELOG.md

@@ -37,6 +37,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+* **role:icingaweb2_module_vspheredb**: Download the module tarball from the canonical `archive/refs/tags/<version>.tar.gz` URL instead of `archive/<version>.tar.gz`, so the pinned release tag is fetched reliably.
 * **role:monitoring_plugins**: A source install now deploys the sudoers drop-in as `/etc/sudoers.d/linuxfabrik-monitoring-plugins`, the same file name the rpm/deb packages use. Both install methods remove the drop-in under the former name `/etc/sudoers.d/monitoring-plugins`, so sudo no longer warns about a duplicate `Cmnd_Alias` on hosts that got the drop-in twice (for example after switching the install method or after running the monitoring-plugins one-liner installer).
 * **role:collect_rpmnew_rpmsave**: Stop emitting an Ansible deprecation warning on every run by making the `when` conditions explicitly boolean. Keeps the role working on Ansible 2.19 and later.
 * **role:kvm_vm**: Use `kvm_vm__connect_url` for every libvirt operation. Disk resizes (`virsh blockresize`) and a few other steps previously ignored the configured connection URL and always talked to the local default, so they failed or acted on the wrong libvirt when `kvm_vm__connect_url` pointed at a non-default or remote host.

roles/icingaweb2_module_vspheredb/tasks/main.yml

@@ -21,9 +21,9 @@
       group: 'icingaweb2'
       mode: 0o755
 
-  - name: 'curl https://github.com/Icinga/icingaweb2-module-vspheredb/archive/{{ icingaweb2_module_vspheredb__version }}.tar.gz --output /tmp/ansible.icingaweb2-module-vspheredb-{{ icingaweb2_module_vspheredb__version }}.tar.gz'
+  - name: 'curl https://github.com/Icinga/icingaweb2-module-vspheredb/archive/refs/tags/{{ icingaweb2_module_vspheredb__version }}.tar.gz --output /tmp/ansible.icingaweb2-module-vspheredb-{{ icingaweb2_module_vspheredb__version }}.tar.gz'
     ansible.builtin.get_url:
-      url: 'https://github.com/Icinga/icingaweb2-module-vspheredb/archive/{{ icingaweb2_module_vspheredb__version }}.tar.gz'
+      url: 'https://github.com/Icinga/icingaweb2-module-vspheredb/archive/refs/tags/{{ icingaweb2_module_vspheredb__version }}.tar.gz'
       dest: '/tmp/ansible.icingaweb2-module-vspheredb-{{ icingaweb2_module_vspheredb__version }}.tar.gz'
     delegate_to: 'localhost'
     become: false