fix(plugins/bitwarden): fix multiple bugs in bitwarden plugins

Author: NavidSassan

CHANGELOG.md

@@ -63,6 +63,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+* **plugin:bitwarden_item**: Fix missing `raise` in multipart error handling, `break` instead of `continue` in multi-term lookup, `folder_id` wrongly typed as `list` instead of `str` in module, notes default mismatch between documentation and code, and wrong "lookup plugin" wording in module documentation
 * **roles**: Fix Ansible 2.19 deprecation warning for conditional results of type `int` by using `| length > 0` instead of `| length`
 * **role:firewall**: Fix fwbuilder repo clone being skipped when `run_once` picks a host without `firewall__fwbuilder_repo_url`
 * **role:sshd**: Validate sshd config with `sshd -t` before reloading the service

plugins/lookup/bitwarden_item.py

@@ -329,7 +329,7 @@ def run(self, terms, variables=None, **kwargs):
                 hostname = term.get('hostname', None)
                 id_ = term.get('id', None)
                 name = term.get('name', None)
-                notes = term.get('notes', 'Automatically generated by Ansible.')
+                notes = term.get('notes', 'Generated by Ansible.')
                 organization_id = term.get('organization_id', None)
                 password_length = term.get('password_length', 60)
                 password_choice = term.get('password_choice', '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ')
@@ -347,7 +347,7 @@ def run(self, terms, variables=None, **kwargs):
                     result['username'] = result['login']['username']
                     result['password'] = result['login']['password']
                     ret.append(result)
-                    break # done here, go to next term
+                    continue # done here, go to next term
                 else:
                     # item not found by ID. if there is an ID given we expect it to exist
                     raise AnsibleError('Item with id {} not found.'.format(id_))

plugins/module_utils/bitwarden.py

@@ -173,7 +173,7 @@ def _api_call(self, url_path, method='GET', body=None, body_format='json'):
                 try:
                     content_type, body = prepare_multipart_no_base64(body)
                 except (TypeError, ValueError) as e:
-                    BitwardenException('failed to parse body as form-multipart: %s' % to_native(e))
+                    raise BitwardenException('failed to parse body as form-multipart: %s' % to_native(e))
                 headers['Content-Type'] = content_type
 
         # mostly taken from ansible.builtin.url lookup plugin

plugins/modules/bitwarden_item.py

@@ -18,8 +18,8 @@
     - If no password item is found, a new item is created. Useful for automation.
     - If you do not specify a name or Bitwarden ID, it searches using the name/title.
     - If there is an existing Bitwarden item that differs from the given parameters, the item is updated, and the updated item is returned.
-    - If a search returns multiple entries, this lookup plugin throws an error, since it cannot decide which one to use.
-    - On success, this lookup plugin returns the complete Bitwarden item object.
+    - If a search returns multiple entries, this module throws an error, since it cannot decide which one to use.
+    - On success, this module returns the complete Bitwarden item object.
     - If you don't specify a name/title for a password item, a name/title will be created automatically, using C(hostname - purpose) (for example "C(dbserver - MariaDB)") or just C(hostname) (for example "C(dbserver)", depending on what is provided).
 
 notes:
@@ -288,7 +288,7 @@ def run_module():
     module_args = dict(
         attachments=dict(type='list', required=False, default=[]),
         collection_id=dict(type='str', required=False, default=None),
-        folder_id=dict(type='list', required=False, default=None),
+        folder_id=dict(type='str', required=False, default=None),
         hostname=dict(type='str', required=False, default=None),
         id=dict(type='str', required=False, default=None),
         name=dict(type='str', required=False, default=None),