Open
Conversation
ebuerki-lf
force-pushed
the
feat/graylog_assert
branch
from
c0dd49d to
aeb2286
Compare
…ssword_secret length
…le in datanode.conf
… allow __raw configs
ebuerki-lf
force-pushed
the
feat/graylog_assert
branch
from
7009d9e to
a2dcb75
Compare
NavidSassan
requested changes
Apr 14, 2026
Member
NavidSassan
left a comment
NavidSassan
left a comment
There was a problem hiding this comment.
don't forget to update the CHANGELOG as well
| - name: 'Validate that graylog_datanode__node_search_cache_size follows OpenSearch Bytes format' | ||
| ansible.builtin.assert: | ||
| that: | ||
| - 'graylog_datanode__node_search_cache_size | regex_search("^[0-9]+(b|kb|mb|gb|tb|pb)$")' |
Member
There was a problem hiding this comment.
Suggested change
| - 'graylog_datanode__node_search_cache_size | regex_search("^[0-9]+(b|kb|mb|gb|tb|pb)$")' | |
| - 'graylog_datanode__node_search_cache_size | ansible.builtin.regex_search("^[0-9]+(b|kb|mb|gb|tb|pb)$")' |
Member
There was a problem hiding this comment.
also please fix the inconsistent indentation
| ansible.builtin.assert: | ||
| that: | ||
| - 'graylog_datanode__node_search_cache_size | regex_search("^[0-9]+(b|kb|mb|gb|tb|pb)$")' | ||
| fail_msg: '"{{ graylog_datanode__node_search_cache_size }}" does not follow OpenSearch Bytes format' |
Member
There was a problem hiding this comment.
Suggested change
| fail_msg: '"{{ graylog_datanode__node_search_cache_size }}" does not follow OpenSearch Bytes format' | |
| fail_msg: '`graylog_datanode__node_search_cache_size: {{ graylog_datanode__node_search_cache_size }}` does not follow OpenSearch Bytes format' |
| graylog_datanode__opensearch_data_location: '/var/lib/graylog-datanode/opensearch/data' | ||
| graylog_datanode__opensearch_heap: '{{ [((ansible_facts["memtotal_mb"] * 0.5) | int), 31744] | min }}m' | ||
| graylog_datanode__mongodb_uri: 'mongodb://127.0.0.1/graylog' | ||
| graylog_datanode__path_repo: [] |
Member
There was a problem hiding this comment.
use plural for lists.
Suggested change
| graylog_datanode__path_repo: [] | |
| graylog_datanode__path_repos: [] |
| # indexer_jwt_auth_token_expiration_duration = 180s | ||
|
|
||
| opensearch_heap = {{ graylog_datanode__opensearch_heap }} | ||
|
|
Member
There was a problem hiding this comment.
dont forget to update the timestamp in the header of the templates
| #### Data Tiering Properties | ||
|
|
||
| node_search_cache_size = {{ graylog_datanode__node_search_cache_size }} | ||
| path_repo = {{ graylog_datanode__path_repo | join(',') }} |
Member
There was a problem hiding this comment.
does this work if graylog_datanode__path_repo is an empty list?
Member
There was a problem hiding this comment.
and is it really comma separated?
Comment on lines
+10
to
+13
| tags: | ||
| - 'graylog_server' | ||
| - 'graylog_server:configure' | ||
|
|
Member
There was a problem hiding this comment.
just use the always tag here (see CONTRIBUTING)
Comment on lines
+105
to
+106
| `graylog_datanode__raw` | ||
| * Multiline string. Raw content which will be appended to the `datanode.conf` config file. |
| `graylog_datanode__node_search_cache_size` | ||
|
|
||
| * Cache size for searchable snaphots. This space will be automatically reserved if `graylog_datanode__path_repo` is configured. See [docs.opensearch.org - Supported Units](https://docs.opensearch.org/latest/api-reference/units/) for a list of possible options. | ||
| * Type: String |
Member
There was a problem hiding this comment.
add a . at the end of the line to be consistent with the roles/example/README.md and the other entries in this file
|
|
||
| `graylog_datanode__node_search_cache_size` | ||
|
|
||
| * Cache size for searchable snaphots. This space will be automatically reserved if `graylog_datanode__path_repo` is configured. See [docs.opensearch.org - Supported Units](https://docs.opensearch.org/latest/api-reference/units/) for a list of possible options. |
Member
There was a problem hiding this comment.
trailing whitespace - make sure you have the pre-commit installed!
| * Type: String. | ||
| * Default: `'mongodb://127.0.0.1/graylog'` | ||
|
|
||
| `graylog_datanode__node_search_cache_size` |
Member
There was a problem hiding this comment.
new variables are missing in the example block at the bottom of this section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.