-
-
Notifications
You must be signed in to change notification settings - Fork 22
feat(roles/grafana): Add JWT support #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
70f78ef
feat(roles/grafana): Add JWT support
danyalberchtoldlf 92dad08
refactor(roles/icingaweb2_module_grafana): clean up and delegate to g…
danyalberchtoldlf dd3f4ee
feat(roles/grafana): add variable for JWT TLS key and issue cert via …
danyalberchtoldlf 453c127
refactor(roles/icingaweb2_module_grafana): fix sort order
danyalberchtoldlf b1f63f1
fix(roles/icingaweb2_module_grafana): fix private key file ownership
danyalberchtoldlf c67b6f3
fix(roles/grafana): correct jwt key file permissions and task conditions
danyalberchtoldlf 5179dac
docs(roles/icingaweb2_module_grafana): update default value for auth_jwt
danyalberchtoldlf 802d1bb
Merge branch 'main' into feat/grafana-jwt
NavidSassan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ Additionally, it deploys the the graph configuration for the [Linuxfabrik Monito | |
|
|
||
| This role is tested with the following IcingaWeb2 Grafana Module versions: | ||
|
|
||
| * 3.0.1 | ||
| * 3.1.3 | ||
|
|
||
|
|
||
| ## Mandatory Requirements | ||
|
|
@@ -36,14 +36,15 @@ Example: | |
| ```yaml | ||
| # mandatory | ||
| icingaweb2_module_grafana__monitoring_plugins_version: '1.2.0.11' | ||
| icingaweb2_module_grafana__version: 'v3.1.1' | ||
| icingaweb2_module_grafana__version: 'v3.1.3' | ||
| ``` | ||
|
|
||
|
|
||
| ## Optional Role Variables | ||
|
|
||
| | Variable | Description | Default Value | | ||
| | -------- | ----------- | ------------- | | ||
| | `icingaweb2_module_grafana__auth_jwt` | Enable JWT-based authentication for Grafana requests | `false` | | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. default is wrong |
||
| | `icingaweb2_module_grafana__custom_graphs_config` | Multiline string. Custom configuration for the Grafana Graphs, will be deployed to `/etc/icingweb2/modules/grafana/graphs.ini` along with the configuration for the [Linuxfabrik Monitoring Plugins](https://github.com/Linuxfabrik/monitoring-plugins) | `''` | | ||
| | `icingaweb2_module_grafana__default_dashboard` | Name of the default Grafana dashboard | `'Default'` | | ||
| | `icingaweb2_module_grafana__skip_monitoring_plugins_graphs_config` | Skip the deployment of the graph configuration for [Linuxfabrik Monitoring Plugins](https://github.com/Linuxfabrik/monitoring-plugins). | `false` | | ||
|
|
@@ -53,6 +54,7 @@ icingaweb2_module_grafana__version: 'v3.1.1' | |
| Example: | ||
| ```yaml | ||
| # optional | ||
| icingaweb2_module_grafana__auth_jwt: false | ||
| icingaweb2_module_grafana__custom_graphs_config: |- | ||
| [icingacli-x509] | ||
| dashboard = "Default" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please sort alphabetically