feat(librenms-alerts,librenms-health): add device-type "management"

markuslf · markuslf · commit 0e7e7a663b48 · 2026-04-07T21:06:32.000+02:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -38,6 +38,8 @@ Monitoring Plugins:
 * by-winrm: executes commands on remote Windows hosts by WinRM, supporting JEA (including the JEA endpoint via `--winrm-configuration-name`)
 * infomaniak-swiss-backup-devices: add `--ignore-customer`, `--ignore-name`, `--ignore-tag`, `--ignore-user` parameters to skip devices by regex
 * infomaniak-swiss-backup-products: add `--ignore-customer`, `--ignore-tag` parameters to skip products by regex
+* librenms-alerts: add device-type `management`
+* librenms-health: add device-type `management`
 * nextcloud-enterprise: provides information about an installed Nextcloud Enterprise subscription
 * procs: add `--lengthy` parameter for extended `--top` table output with all platform-specific memory fields
 * procs: add `--top` parameter to list the top N processes by CPU time and memory usage
diff --git a/check-plugins/librenms-alerts/README.md b/check-plugins/librenms-alerts/README.md
@@ -32,7 +32,7 @@ usage: librenms-alerts [-h] [-V] [--always-ok] [--defaults-file DEFAULTS_FILE]
                        [--defaults-group DEFAULTS_GROUP]
                        [--device-group DEVICE_GROUP]
                        [--device-hostname DEVICE_HOSTNAME]
-                       [--device-type {appliance,collaboration,environment,firewall,loadbalancer,network,power,printer,server,storage,wireless,workstation}]
+                       [--device-type {appliance,collaboration,environment,firewall,loadbalancer,management,network,power,printer,server,storage,wireless,workstation}]
                        [--lengthy] [--severity {warn,crit}]
                        [--timeout TIMEOUT]
 
@@ -63,7 +63,7 @@ options:
                         Wildcards.
   --device-hostname DEVICE_HOSTNAME
                         Filter by LibreNMS Hostname (repeating).
-  --device-type {appliance,collaboration,environment,firewall,loadbalancer,network,power,printer,server,storage,wireless,workstation}
+  --device-type {appliance,collaboration,environment,firewall,loadbalancer,management,network,power,printer,server,storage,wireless,workstation}
                         Filter by LibreNMS Device Type (repeating).
   --lengthy             Extended reporting.
   --severity {warn,crit}
diff --git a/check-plugins/librenms-alerts/icingaweb2-module-director/librenms-alerts.json b/check-plugins/librenms-alerts/icingaweb2-module-director/librenms-alerts.json
@@ -182,6 +182,12 @@
                     "format": "string",
                     "allowed_roles": null
                 },
+                {
+                    "entry_name": "management",
+                    "entry_value": "Management",
+                    "format": "string",
+                    "allowed_roles": null
+                },
                 {
                     "entry_name": "network",
                     "entry_value": "Network",
diff --git a/check-plugins/librenms-alerts/librenms-alerts b/check-plugins/librenms-alerts/librenms-alerts
@@ -11,19 +11,19 @@
 """See the check's README for more details.
 """
 
-import argparse  # pylint: disable=C0413
-import sys  # pylint: disable=C0413
-
-import lib.base  # pylint: disable=C0413
-import lib.db_mysql  # pylint: disable=C0413
-import lib.human  # pylint: disable=C0413
-import lib.librenms  # pylint: disable=C0413
-import lib.txt  # pylint: disable=C0413
-from lib.globals import (STATE_CRIT, STATE_OK,  # pylint: disable=C0413
+import argparse
+import sys
+
+import lib.base
+import lib.db_mysql
+import lib.human
+import lib.librenms
+import lib.txt
+from lib.globals import (STATE_CRIT, STATE_OK,
                           STATE_UNKNOWN, STATE_WARN)
 
 __author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
-__version__ = '2025100601'
+__version__ = '2026040801'
 
 DESCRIPTION = """This check warns of unacknowledged alerts in LibreNMS and
                  reports the most recent alert for each device (only for those
@@ -52,7 +52,7 @@ def parse_args():
     parser.add_argument(
         '-V', '--version',
         action='version',
-        version='{0}: v{1} by {2}'.format('%(prog)s', __version__, __author__)
+        version=f'%(prog)s: v{__version__} by {__author__}'
     )
 
     parser.add_argument(
@@ -99,12 +99,13 @@ def parse_args():
         help='Filter by LibreNMS Device Type (repeating).',
         dest='DEVICE_TYPE',
         action='append',
-        choices=[ # taken from the librenms source file misc/config_definitions.json
+        choices=[ # taken from the librenms source file resources/definitions/config_definitions.json
             'appliance',
             'collaboration',
             'environment',
             'firewall',
             'loadbalancer',
+            'management',
             'network',
             'power',
             'printer',
@@ -171,7 +172,7 @@ def main():
 
     # fetch data
     sql = '''
-        SELECT 
+        SELECT
             d.hardware,
             d.hostname,
             d.os,
@@ -203,14 +204,10 @@ def main():
         sql += ' AND dg.name LIKE %s '
         data.append(args.DEVICE_GROUP)
     if args.DEVICE_HOSTNAME:
-        sql += ' AND d.hostname IN ({}) '.format(
-            ', '.join('%s' for d in args.DEVICE_HOSTNAME), # print "%s" for each argument
-        )
+        sql += f' AND d.hostname IN ({", ".join("%s" for _ in args.DEVICE_HOSTNAME)}) '
         data += args.DEVICE_HOSTNAME
     if args.DEVICE_TYPE:
-        sql += ' AND d.type IN ({}) '.format(
-            ', '.join('%s' for d in args.DEVICE_TYPE), # print "%s" for each argument
-        )
+        sql += f' AND d.type IN ({", ".join("%s" for _ in args.DEVICE_TYPE)}) '
         data += args.DEVICE_TYPE
     devices = lib.base.coe(lib.db_mysql.select(conn, sql, data))
     lib.db_mysql.close(conn)
@@ -240,19 +237,21 @@ def main():
     if state == STATE_OK:
         msg = 'Everything is ok. '
     else:
-        msg = 'There {} {} {}. '.format(
-            lib.txt.pluralize('', alert_count, 'is,are'),
-            alert_count,
-            lib.txt.pluralize('alert', alert_count),
-        )
-    msg += 'Checked {} {}.'.format(
-        device_count,
-        lib.txt.pluralize('device', device_count),
-    )
+        msg = f'There {lib.txt.pluralize("", alert_count, "is,are")} ' \
+              f'{alert_count} {lib.txt.pluralize("alert", alert_count)}. '
+    msg += f'Checked {device_count} {lib.txt.pluralize("device", device_count)}.'
     msg += '\n\n'
 
-    perfdata += lib.base.get_perfdata('device_count', device_count, None, None, None, 0, None) # pylint: disable=C0301
-    perfdata += lib.base.get_perfdata('alert_count', alert_count, None, None, None, 0, None) # pylint: disable=C0301
+    perfdata += lib.base.get_perfdata(
+        'device_count',
+        device_count,
+        _min=0,
+    )
+    perfdata += lib.base.get_perfdata(
+        'alert_count',
+        alert_count,
+        _min=0,
+    )
 
     if device_count > 0:
         if not args.LENGTHY:
@@ -305,5 +304,5 @@ def main():
 if __name__ == '__main__':
     try:
         main()
-    except Exception:   # pylint: disable=W0703
+    except Exception:
         lib.base.cu()
diff --git a/check-plugins/librenms-health/README.md b/check-plugins/librenms-health/README.md
@@ -32,7 +32,7 @@ usage: librenms-health [-h] [-V] [--always-ok] [--defaults-file DEFAULTS_FILE]
                        [--defaults-group DEFAULTS_GROUP]
                        [--device-group DEVICE_GROUP]
                        [--device-hostname DEVICE_HOSTNAME]
-                       [--device-type {appliance,collaboration,environment,firewall,loadbalancer,network,power,printer,server,storage,wireless,workstation}]
+                       [--device-type {appliance,collaboration,environment,firewall,loadbalancer,management,network,power,printer,server,storage,wireless,workstation}]
                        [--lengthy] [--timeout TIMEOUT]
 
 This check plugin retrieves sensor information for each device from a LibreNMS
@@ -58,7 +58,7 @@ options:
                         Wildcards.
   --device-hostname DEVICE_HOSTNAME
                         Filter by LibreNMS Hostname (repeating).
-  --device-type {appliance,collaboration,environment,firewall,loadbalancer,network,power,printer,server,storage,wireless,workstation}
+  --device-type {appliance,collaboration,environment,firewall,loadbalancer,management,network,power,printer,server,storage,wireless,workstation}
                         Filter by LibreNMS Device Type (repeating).
   --lengthy             Extended reporting.
   --timeout TIMEOUT     Network timeout in seconds. Default: 3 (seconds)
diff --git a/check-plugins/librenms-health/icingaweb2-module-director/librenms-health.json b/check-plugins/librenms-health/icingaweb2-module-director/librenms-health.json
@@ -173,6 +173,12 @@
                     "format": "string",
                     "allowed_roles": null
                 },
+                {
+                    "entry_name": "management",
+                    "entry_value": "Management",
+                    "format": "string",
+                    "allowed_roles": null
+                },
                 {
                     "entry_name": "network",
                     "entry_value": "Network",
diff --git a/check-plugins/librenms-health/librenms-health b/check-plugins/librenms-health/librenms-health
@@ -11,19 +11,19 @@
 """See the check's README for more details.
 """
 
-import argparse  # pylint: disable=C0413
-import sys  # pylint: disable=C0413
-
-import lib.base  # pylint: disable=C0413
-import lib.db_mysql  # pylint: disable=C0413
-import lib.human  # pylint: disable=C0413
-import lib.librenms  # pylint: disable=C0413
-import lib.time  # pylint: disable=C0413
-from lib.globals import (STATE_CRIT, STATE_OK,  # pylint: disable=C0413
+import argparse
+import sys
+
+import lib.base
+import lib.db_mysql
+import lib.human
+import lib.librenms
+import lib.time
+from lib.globals import (STATE_CRIT, STATE_OK,
                           STATE_UNKNOWN, STATE_WARN)
 
 __author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
-__version__ = '2025100601'
+__version__ = '2026040801'
 
 DESCRIPTION = """This check plugin retrieves sensor information for each device
                  from a LibreNMS instance.
@@ -49,7 +49,7 @@ def parse_args():
     parser.add_argument(
         '-V', '--version',
         action='version',
-        version='%(prog)s: v{} by {}'.format(__version__, __author__)
+        version=f'%(prog)s: v{__version__} by {__author__}'
     )
 
     parser.add_argument(
@@ -96,12 +96,13 @@ def parse_args():
         help='Filter by LibreNMS Device Type (repeating).',
         dest='DEVICE_TYPE',
         action='append',
-        choices=[ # taken from the librenms source file misc/config_definitions.json
+        choices=[ # taken from the librenms source file resources/definitions/config_definitions.json
             'appliance',
             'collaboration',
             'environment',
             'firewall',
             'loadbalancer',
+            'management',
             'network',
             'power',
             'printer',
@@ -159,7 +160,7 @@ def main():
 
     # fetch data
     sql = '''
-        SELECT 
+        SELECT
             d.hostname,
             d.sysName,
             d.sysDescr,
@@ -197,14 +198,10 @@ def main():
         sql += ' AND dg.name LIKE %s '
         data.append(args.DEVICE_GROUP)
     if args.DEVICE_HOSTNAME:
-        sql += ' AND d.hostname IN ({}) '.format(
-            ', '.join('%s' for d in args.DEVICE_HOSTNAME), # print "%s" for each argument
-        )
+        sql += f' AND d.hostname IN ({", ".join("%s" for _ in args.DEVICE_HOSTNAME)}) '
         data += args.DEVICE_HOSTNAME
     if args.DEVICE_TYPE:
-        sql += ' AND d.type IN ({}) '.format(
-            ', '.join('%s' for d in args.DEVICE_TYPE), # print "%s" for each argument
-        )
+        sql += f' AND d.type IN ({", ".join("%s" for _ in args.DEVICE_TYPE)}) '
         data += args.DEVICE_TYPE
     sql += ' ORDER BY d.hostname, s.sensor_class'
     sensors = lib.base.coe(lib.db_mysql.select(conn, sql, data))
@@ -218,11 +215,7 @@ def main():
         if sensor['sensor_class'] == 'state':
             sensors[i]['sensor_current'] = sensor['state_descr']
         if all([sensor['sensor_limit_low'], sensor['sensor_limit']]):
-            sensor['sensor_current'] = '{} ({}..{})'.format(
-                sensor['sensor_current'],
-                sensor['sensor_limit_low'],
-                sensor['sensor_limit'],
-            )
+            sensor['sensor_current'] = f'{sensor["sensor_current"]} ({sensor["sensor_limit_low"]}..{sensor["sensor_limit"]})'
         if sensor['lastupdate']:
             delta = lib.time.now(as_type='datetime') - sensor['lastupdate']
             sensor['lastupdate'] = lib.human.seconds2human(delta.total_seconds())
@@ -246,19 +239,21 @@ def main():
     if state == STATE_OK:
         msg = 'Everything is ok. '
     else:
-        msg = 'There {} {} {}. '.format(
-            lib.txt.pluralize('', alert_count, 'is,are'),
-            alert_count,
-            lib.txt.pluralize('alert', alert_count),
-        )
-    msg += 'Checked {} {}.'.format(
-        sensors_count,
-        lib.txt.pluralize('sensor', sensors_count),
-    )
+        msg = f'There {lib.txt.pluralize("", alert_count, "is,are")} ' \
+              f'{alert_count} {lib.txt.pluralize("alert", alert_count)}. '
+    msg += f'Checked {sensors_count} {lib.txt.pluralize("sensor", sensors_count)}.'
     msg += '\n\n'
 
-    perfdata += lib.base.get_perfdata('sensor_count', sensors_count, None, None, None, 0, None) # pylint: disable=C0301
-    perfdata += lib.base.get_perfdata('alert_count', alert_count, None, None, None, 0, None) # pylint: disable=C0301
+    perfdata += lib.base.get_perfdata(
+        'sensor_count',
+        sensors_count,
+        _min=0,
+    )
+    perfdata += lib.base.get_perfdata(
+        'alert_count',
+        alert_count,
+        _min=0,
+    )
 
     if sensors_count > 0:
         if not args.LENGTHY:
@@ -313,5 +308,5 @@ def main():
 if __name__ == '__main__':
     try:
         main()
-    except Exception:   # pylint: disable=W0703
+    except Exception:
         lib.base.cu()
