Commit 1f7acc7
committed
style: strip free-text rationales from bandit # nosec comments
bandit's nosec parser tokenizes every word after `# nosec BXXX` and
tries to match it against its test-id catalog, emitting a
"Test in comment: WORD is not a test name or id, ignoring" warning
for each one. Seven plugins carried rationales inline with the nosec
which produced 30 noisy warnings across the linter sweep:
- dhcp-relayed (2x B104)
- kemp-services (1x B405)
- keycloak-memory-usage, keycloak-stats, keycloak-version (3x B105)
- matomo-reporting (1x B105)
- openstack-nova-list (1x B105)
Move each rationale into a plain comment on the line above the
suppressed statement (except kemp-services where the import block
does not tolerate a gap; its context is already obvious from the
plugin name) and keep the `# nosec BXXX` alone on the suppressed
line. Functionally unchanged; the linter sweep now runs without
the spurious "Test in comment" warnings.1 parent 6e42a70 commit 1f7acc7
7 files changed
Lines changed: 17 additions & 8 deletions
File tree
- check-plugins
- dhcp-relayed
- kemp-services
- keycloak-memory-usage
- keycloak-stats
- keycloak-version
- matomo-reporting
- openstack-nova-list
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
36 | 38 | | |
37 | 39 | | |
38 | 40 | | |
| |||
362 | 364 | | |
363 | 365 | | |
364 | 366 | | |
365 | | - | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
366 | 370 | | |
367 | 371 | | |
368 | 372 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
| 32 | + | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
| 39 | + | |
39 | 40 | | |
40 | 41 | | |
41 | 42 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
228 | | - | |
| 228 | + | |
| 229 | + | |
229 | 230 | | |
230 | 231 | | |
231 | 232 | | |
| |||
0 commit comments