Skip to content

Commit 5d2adba

Browse files
committed
fix(check2basket): fix importlib imports and handle append defaults
1 parent e8ba94e commit 5d2adba

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

tools/check2basket

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@
1010

1111
import argparse
1212
import importlib
13+
import importlib.machinery
14+
import importlib.util
1315
import json
1416
import os
1517
import re
@@ -647,6 +649,11 @@ def parse_plugin_args(data, plugin_args, check_name, command_object_name, servic
647649
data[service_object_parent_key][service_object_name]['vars'][varname] = sanitize_default_value(action.default)
648650
else:
649651
data[service_object_parent_key][service_object_name]['vars'][varname] = action.default
652+
elif isinstance(action, argparse._AppendAction):
653+
# append parameters use default=None to avoid the argparse
654+
# bug where user values are appended to the default list
655+
# instead of replacing it; treat as empty list in the basket
656+
data[service_object_parent_key][service_object_name]['vars'][varname] = []
650657

651658
command_field_id += 1
652659
continue

0 commit comments

Comments
 (0)