fix(plugins): wrong identifier / swapped fields (#1070)

Eight plugins referenced the wrong variable or dict key in a message
or perfdata call. The message text was often correct in each case,
but the emitted numeric value or state label did not match.

- hin-status: `cnt_incidents = 1` was hardcoded whenever the parser
  found any incident, instead of `len(incidents)`. The perfdata
  counter now tracks the real count.
- mysql-table-locks: the "X immediate / Y locks" denominator used
  `Table_locks_immediate` twice. Use the actual total
  (`Table_locks_immediate + Table_locks_waited`) as Y.
- ntp-w32tm: when "Time since Last Good Sync Time" ticks into CRIT,
  the appended state label hardcoded STATE_WARN. Use the actual
  `local_state` instead.
- openstack-swift-stat: the "bytes used" block gated on the quota
  header `x-account-meta-quota-bytes` when it should have gated on
  `x-account-bytes-used`. The "used" line now shows up for any
  account with non-zero bytes, regardless of whether a quota is set.
- php-status: the "missing config" builder appended
  `'{key} = {value}, '` as a plain string, so the output contained
  literal `{key}` / `{value}` placeholders. Make it an f-string.
- qts-temperatures: the `systemp` and `cputemp` perfdata entries had
  their `warn` / `crit` thresholds swapped - the sys perfdata used
  `CPUTempWarnT`/`CPUTempErrT` and the cpu perfdata used
  `SysTempWarnT`/`SysTempErrT`. The message text was already correct.
- redis-status, valkey-status: the `key_count` perfdata value used
  the loop variable `keys` (the last database's per-DB key count)
  instead of the accumulated `key_count` total. The "with X keys"
  message text was already using `key_count` correctly.

php-fpm-ping was also flagged but turned out to be intentional: the
plugin has no response-time metric (it only compares strings), so
emitting the state integer as the perfdata value is a conscious
design choice rather than a bug.

Author: markuslf

CHANGELOG.md

@@ -14,13 +14,20 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * axenita-stats: fix the version-number extraction slice `[8 : 8 + find('-') - 1]` that only worked for exactly 6-character versions like `14.0.8` and silently truncated any longer patch number. Use `split('-')[1]` instead, which handles `14.0.12`, `1.2.3`, and 2-digit majors correctly ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * deb-updates: add missing `lib.txt` import so the "N update(s) available" summary no longer crashes with `AttributeError` at runtime
 * Fix `--require-hashes` pip install in pre-commit autoupdate workflow by using pinned version instead
+* hin-status: when incidents are found, set `cnt_incidents = len(incidents)` instead of the hardcoded `1`, so the perfdata counter matches the actual number of incidents listed in the message ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * keycloak-version: replace the fragile regex `r'n (.*)'` (which relied on the "n " in the word "Version" of `/opt/keycloak/version.txt`) with an explicit `r'[Vv]ersion\s+(\d+(?:\.\d+)*)'` pattern. Also fall through to the API fallback when the file is present but the regex does not match, instead of aborting with "Keycloak not found" ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * mysql-memory: fix `get_other_process_memory()` fallback path for psutil older than 5.3.0 (referenced an undefined `cmdline` variable and the wrong attribute on the process dict) and drop an unreachable `break` after `return` in `get_pfs_memory()`
 * mysql-storage-engines: drop a dead `SELECT ... FROM information_schema.engines` query whose result was never used
+* mysql-table-locks: the "X immediate / Y locks" message denominator used `Table_locks_immediate` twice instead of `Table_locks_immediate + Table_locks_waited` as the total, so the output lied about the total lock count. The ratio displayed as a percentage was already correct ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * network-connections: the final `lib.base.oao()` call passed a hardcoded `STATE_OK` instead of the accumulated `state`, discarding all WARN/CRIT decisions from the loop. The plugin now exits with the correct accumulated state ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * ntp-ntpd: collapse four sequential `if`-then-`oao()` early-exit guards into a single `if/elif` chain so the intent (try each failure mode in turn and exit on the first one that matches) is explicit ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
+* ntp-w32tm: when the "Time since Last Good Sync Time" check yields a non-OK state, the appended state label is now the actual `local_state` (WARN or CRIT) instead of a hardcoded `STATE_WARN`, so a CRIT state no longer shows up as "WARNING" in the message ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
+* openstack-swift-stat: the "bytes used" block gated on `'x-account-meta-quota-bytes' in headers` (a quota header) when it should have gated on `'x-account-bytes-used' in headers`. The "used" line now shows up for any account with non-zero bytes, regardless of whether a quota is set ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * openvpn-version: replace the fragile regex `r'N (\d+\.\d+\.\d+)'` (which relied on the "N" at the end of "OpenVPN") with an explicit `r'OpenVPN\s+(\d+\.\d+\.\d+)'` pattern anchored on the command name ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
+* php-status: the "missing config" builder appended `'{key} = {value}, '` as a plain string instead of an f-string, so the output contained literal `{key}` / `{value}` placeholders. Mark it as an f-string so the real key/value is rendered ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * ping: drop dead initialization of `rtt_min / rtt_avg / rtt_max / rtt_mdev` that was never read
+* qts-temperatures: the `systemp` and `cputemp` perfdata entries had their `warn` / `crit` thresholds swapped (system perfdata used the CPU threshold fields and vice versa). The message text was already correct ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
+* redis-status, valkey-status: the `key_count` perfdata value used the loop variable `keys` (the last database's per-DB key count) instead of the accumulated `key_count` (total across all databases). The "with X keys" message text was already using `key_count` ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * rocketchat-stats: add missing `lib.txt` import so the user-count pluralization no longer crashes with `AttributeError` at runtime
 * starface-java-memory-usage: the heap and non-heap state checks used `state += lib.base.get_worst(used_state, state)` which adds state integers together and corrupts the accumulated state (e.g. WARN+WARN=2 reads as CRIT, WARN+CRIT=3 is outside the valid range). Replaced with `state = lib.base.get_worst(state, used_state)` so the accumulated state remains a valid STATE_OK / STATE_WARN / STATE_CRIT value ([#1070](https://github.com/Linuxfabrik/monitoring-plugins/issues/1070))
 * tools/run-unit-tests: skip the `example` plugin in default runs. Its unit test is a template meant to be copy-pasted into new plugins and does not correspond to a real check. Explicit `python tools/run-unit-tests example` still runs it

check-plugins/hin-status/hin-status

@@ -27,7 +27,7 @@ except ImportError:
 
 
 __author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
-__version__ = '2025100601'
+__version__ = '2026041201'
 
 DESCRIPTION = """Monitors the HIN (Health Info Net) status page for service disruptions. Parses the
 support website for outage announcements since no machine-readable API is available.
@@ -146,7 +146,7 @@ def main():
                 'div', class_='hin-status-block-content'
             ).find_all('li'):
                 incidents.append(incident.get_text(strip=True))
-            cnt_incidents = 1
+            cnt_incidents = len(incidents)
             state = STATE_WARN
             msg += f'Incidents: {", ".join(incidents)}. See {args.URL} for details.'
         except AttributeError:

check-plugins/mysql-table-locks/mysql-table-locks

@@ -20,7 +20,7 @@ import lib.human
 from lib.globals import STATE_OK, STATE_UNKNOWN, STATE_WARN
 
 __author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
-__version__ = '2026040801'
+__version__ = '2026041201'
 
 DESCRIPTION = """Checks the rate of table locks that had to wait in MySQL/MariaDB. A high wait rate
 indicates contention between concurrent queries.
@@ -137,12 +137,13 @@ def main():
         mycalc['pct_table_locks_immediate'] = 0
 
     # Table locks
+    total_locks = int(mystat['Table_locks_immediate']) + int(mystat['Table_locks_waited'])
     msg = (
         f'{mycalc["pct_table_locks_immediate"]}% table locks'
         f' acquired immediately'
         f' ({lib.human.number2human(mystat["Table_locks_immediate"])}'
         f' immediate /'
-        f' {lib.human.number2human(mystat["Table_locks_immediate"])}'
+        f' {lib.human.number2human(total_locks)}'
         f' locks)'
     )
     if mycalc['pct_table_locks_immediate'] < 95:

check-plugins/ntp-w32tm/ntp-w32tm

@@ -22,7 +22,7 @@ import lib.txt
 from lib.globals import STATE_OK, STATE_UNKNOWN, STATE_WARN
 
 __author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
-__version__ = '2025120201'
+__version__ = '2026041201'
 
 DESCRIPTION = """Checks the Windows Time Service (w32tm) status, including clock offset, stratum,
 and time source. Useful for diagnosing time synchronization issues on Windows
@@ -170,7 +170,7 @@ def main():
                 time_since_last_good_sync_time, args.WARN, args.CRIT
             )
             if local_state != STATE_OK:
-                msg.append(f'{line} {lib.base.state2str(STATE_WARN)}')
+                msg.append(f'{line} {lib.base.state2str(local_state)}')
             state = lib.base.get_worst(local_state, state)
 
     # build the message

check-plugins/openstack-swift-stat/openstack-swift-stat

@@ -31,7 +31,7 @@ except ImportError:
 
 
 __author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
-__version__ = '2026040801'
+__version__ = '2026041201'
 
 DESCRIPTION = """Checks OpenStack Swift object storage account statistics, including total container
 count, object count, and bytes used. Alerts when storage usage exceeds the configured
@@ -253,7 +253,7 @@ def main():
             f'{lib.human.number2human(obj_cnt)}'
             f' {lib.txt.pluralize("object", int(obj_cnt))}, '
         )
-    if 'x-account-meta-quota-bytes' in stat_account['headers'] and int(
+    if 'x-account-bytes-used' in stat_account['headers'] and int(
         stat_account['headers']['x-account-bytes-used']
     ):
         bytes_used = int(stat_account['headers']['x-account-bytes-used'])

check-plugins/php-status/php-status

@@ -22,7 +22,7 @@ from lib.globals import STATE_OK, STATE_UNKNOWN, STATE_WARN
 
 
 __author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
-__version__ = '2026033101'
+__version__ = '2026041201'
 
 DESCRIPTION = """Checks PHP configuration and health, including startup errors, missing modules, and
 misconfigured php.ini directives. Optionally reads extended PHP information from a
@@ -193,7 +193,7 @@ def get_config_errors(args):
         except Exception:
             continue
         if f'{key.lower()} => {value.lower()}' not in php_config:
-            result += '{key} = {value}, '
+            result += f'{key} = {value}, '
     if result:
         result = result[:-2] + ' (did you run the check with sudo?), '
     return result

check-plugins/qts-temperatures/qts-temperatures

@@ -28,7 +28,7 @@ except ImportError:
 
 
 __author__ = 'Linuxfabrik GmbH, Zurich/Switzerland'
-__version__ = '2026040801'
+__version__ = '2026041201'
 
 DESCRIPTION = """Checks system and disk temperatures on QNAP appliances running QTS via the API.
 Alerts when temperatures exceed the configured thresholds."""
@@ -162,15 +162,15 @@ def main():
     perfdata = lib.base.get_perfdata(
         'systemp',
         int(data['func']['ownContent']['root']['sys_tempc']),
-        warn=int(data['func']['ownContent']['root']['CPUTempWarnT']),
-        crit=int(data['func']['ownContent']['root']['CPUTempErrT']),
+        warn=int(data['func']['ownContent']['root']['SysTempWarnT']),
+        crit=int(data['func']['ownContent']['root']['SysTempErrT']),
         _min=0,
     )
     perfdata += lib.base.get_perfdata(
         'cputemp',
         int(data['func']['ownContent']['root']['cpu_tempc']),
-        warn=int(data['func']['ownContent']['root']['SysTempWarnT']),
-        crit=int(data['func']['ownContent']['root']['SysTempErrT']),
+        warn=int(data['func']['ownContent']['root']['CPUTempWarnT']),
+        crit=int(data['func']['ownContent']['root']['CPUTempErrT']),
         _min=0,
     )
 

check-plugins/redis-status/redis-status

@@ -25,7 +25,7 @@ from lib.globals import STATE_OK, STATE_UNKNOWN, STATE_WARN
 __author__ = """
 Linuxfabrik GmbH, Zurich/Switzerland;
 """
-__version__ = '2025103001'
+__version__ = '2026041201'
 
 DESCRIPTION = """Monitors a Redis server via the INFO command. Reports memory usage, fragmentation ratio,
 keyspace hit rate, connected clients, replication status, and persistence state. Alerts
@@ -379,7 +379,7 @@ def main():
         )
         perfdata += lib.base.get_perfdata(
             'key_count',
-            keys,
+            key_count,
             uom=None,
             warn=None,
             crit=None,

check-plugins/valkey-status/valkey-status

@@ -25,7 +25,7 @@ __author__ = """
 Linuxfabrik GmbH, Zurich/Switzerland;
 enhanced by Claudio Kuenzler
 """
-__version__ = '2025103001'
+__version__ = '2026041201'
 
 DESCRIPTION = """Monitors a Valkey server via the INFO command. Reports memory usage, fragmentation
 ratio, keyspace hit rate, connected clients, replication status, and persistence state.
@@ -374,7 +374,7 @@ def main():
         )
         perfdata += lib.base.get_perfdata(
             'key_count',
-            keys,
+            key_count,
             uom=None,
             warn=None,
             crit=None,