feat(podman-info,podman-stats): add dedicated Podman checks (fix #1023)

- Add podman-info and podman-stats as dedicated Podman counterparts
  to docker-info and docker-stats
- Add Podman Service Set to Icinga Director basket
- Modernize docker-info and docker-stats (remove pylint directives,
  fix bare except, use example-plugin perfdata format)
- Fix docker-stats memory perfdata using CPU thresholds instead of
  memory thresholds
- docker-info and docker-stats now detect Podman and point to the
  correct check

Author: markuslf

CHANGELOG.md

@@ -44,6 +44,8 @@ Monitoring Plugins:
 * librenms-alerts: add device-type `management`
 * librenms-health: add device-type `management`
 * nextcloud-enterprise: provides information about an installed Nextcloud Enterprise subscription
+* podman-info: displays system-wide Podman information (dedicated Podman counterpart to docker-info) ([#1023](https://github.com/Linuxfabrik/monitoring-plugins/issues/1023))
+* podman-stats: prints cpu and memory statistics for all running Podman containers (dedicated Podman counterpart to docker-stats) ([#1023](https://github.com/Linuxfabrik/monitoring-plugins/issues/1023))
 * procs: add `--lengthy` parameter for extended `--top` table output with all platform-specific memory fields
 * procs: add `--top` parameter to list the top N processes by CPU time and memory usage
 * procs: add `--warning-cpu-percent` / `--critical-cpu-percent` thresholds for aggregated CPU usage of filtered processes (requires SQLite for delta calculation between runs)
@@ -129,6 +131,7 @@ Monitoring Plugins:
 * about-me: fix various errors with `sys_dimensions` on some machines ([#1006](https://github.com/Linuxfabrik/monitoring-plugins/issues/1006))
 * by-ssh: add missing `--verbose` parameter
 * cpu-usage: fix false 100% readings on Windows with 64+ cores caused by all-zero CPU time samples from psutil ([#626](https://github.com/Linuxfabrik/monitoring-plugins/issues/626))
+* docker-stats: fix memory perfdata using CPU thresholds instead of memory thresholds
 * file-age: handle `FileNotFoundError` race condition when files disappear on busy file systems
 * fs-ro: ignore `/run/credentials` (https://systemd.io/CREDENTIALS/)
 * keycloak-stats: fix incorrect symlink for lib

assets/icingaweb2-module-director/all-the-rest.json

@@ -1335,6 +1335,12 @@
                     "entry_value": "pip",
                     "format": "string"
                 },
+                {
+                    "allowed_roles": null,
+                    "entry_name": "podman",
+                    "entry_value": "Podman",
+                    "format": "string"
+                },
                 {
                     "allowed_roles": null,
                     "entry_name": "postfix-mta",
@@ -40782,6 +40788,101 @@
             },
             "uuid": "f2ebcf70-f8fc-4a4d-920d-0adead6d220c"
         },
+        "Podman Service Set": {
+            "assign_filter": "\"podman\"=host.vars.tags",
+            "description": null,
+            "object_name": "Podman Service Set",
+            "object_type": "template",
+            "services": {
+                "Podman Info": {
+                    "action_url": null,
+                    "apply_for": null,
+                    "assign_filter": null,
+                    "check_command": null,
+                    "check_interval": null,
+                    "check_period": null,
+                    "check_timeout": null,
+                    "command_endpoint": null,
+                    "disabled": false,
+                    "display_name": null,
+                    "enable_active_checks": null,
+                    "enable_event_handler": null,
+                    "enable_flapping": null,
+                    "enable_notifications": null,
+                    "enable_passive_checks": null,
+                    "enable_perfdata": null,
+                    "event_command": null,
+                    "fields": [],
+                    "flapping_threshold_high": null,
+                    "flapping_threshold_low": null,
+                    "groups": [],
+                    "host": null,
+                    "icon_image": null,
+                    "icon_image_alt": null,
+                    "imports": [
+                        "tpl-service-podman-info"
+                    ],
+                    "max_check_attempts": null,
+                    "notes": null,
+                    "notes_url": null,
+                    "object_name": "Podman Info",
+                    "object_type": "object",
+                    "retry_interval": null,
+                    "service_set": null,
+                    "template_choice": null,
+                    "use_agent": null,
+                    "use_var_overrides": null,
+                    "uuid": "2c5186be-dbf0-476e-9167-007418bdc11e",
+                    "vars": {},
+                    "volatile": null,
+                    "zone": null
+                },
+                "Podman Stats": {
+                    "action_url": null,
+                    "apply_for": null,
+                    "assign_filter": null,
+                    "check_command": null,
+                    "check_interval": null,
+                    "check_period": null,
+                    "check_timeout": null,
+                    "command_endpoint": null,
+                    "disabled": false,
+                    "display_name": null,
+                    "enable_active_checks": null,
+                    "enable_event_handler": null,
+                    "enable_flapping": null,
+                    "enable_notifications": null,
+                    "enable_passive_checks": null,
+                    "enable_perfdata": null,
+                    "event_command": null,
+                    "fields": [],
+                    "flapping_threshold_high": null,
+                    "flapping_threshold_low": null,
+                    "groups": [],
+                    "host": null,
+                    "icon_image": null,
+                    "icon_image_alt": null,
+                    "imports": [
+                        "tpl-service-podman-stats"
+                    ],
+                    "max_check_attempts": null,
+                    "notes": null,
+                    "notes_url": null,
+                    "object_name": "Podman Stats",
+                    "object_type": "object",
+                    "retry_interval": null,
+                    "service_set": null,
+                    "template_choice": null,
+                    "use_agent": null,
+                    "use_var_overrides": null,
+                    "uuid": "d3e54d97-d793-4622-9f64-22a6b3d4cef3",
+                    "vars": {},
+                    "volatile": null,
+                    "zone": null
+                }
+            },
+            "uuid": "5701b472-29c0-45d6-83db-921f07f1fc33"
+        },
         "Postfix MTA Service Set": {
             "assign_filter": "\"postfix-mta\"=host.vars.tags",
             "description": null,

check-plugins/docker-info/README.md

@@ -2,7 +2,7 @@
 
 ## Overview
 
-Displays system-wide docker or podman information.
+Displays system-wide Docker information. For Podman, use the [podman-info](https://github.com/Linuxfabrik/monitoring-plugins/tree/main/check-plugins/podman-info) check instead.
 
 
 ## Fact Sheet
@@ -20,7 +20,8 @@ Displays system-wide docker or podman information.
 ```text
 usage: docker-info [-h] [-V] [--always-ok] [--test TEST]
 
-Displays system-wide docker information.
+Displays system-wide Docker information. For Podman, use the podman-info check
+instead.
 
 options:
   -h, --help     show this help message and exit