Commit 9302783
committed
docs(build): point build-id comment at the merged VS Code precedent
Re-read the issues and linked PRs more carefully after a review
comment. The inline comment in both spec files cited
Azure/azure-cli#23798 as the canonical reference for the
`_build_id_links none` workaround, but that PR has been open
(not merged) since 2022; the azure-cli maintainers were actually
sceptical on the linked Azure/azure-cli#23559 discussion and
never integrated the fix.
The real precedent is microsoft/vscode#116105, which used the
exact same `%define _build_id_links none` line and was merged in
February 2021 to solve the same class of conflict between the
`code` and `code-insiders` RPMs (both ship the same Electron
binary). VS Code has been shipping this workaround for nearly
five years with no reported side effects.
Update both spec file comments to reference the merged VS Code
fix as the primary precedent and keep azure-cli only as "this is
where the conflict in issue #979 was reported", not as a
canonical-fix citation. Also broaden the example of the
colliding shared object beyond libpython - in practice the same
thing happens to ordinary compiled wheels like charset_normalizer
(see the datadog-agent reports on Azure/azure-cli#23559).
No code change, no CHANGELOG churn.1 parent 5881624 commit 9302783
File tree
2 files changed
+18
-12
lines changed- build
2 files changed
+18
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
20 | 23 | | |
21 | 24 | | |
22 | 25 | | |
| |||
0 commit comments