Improve rendering reliability if baking fails

Author: CodeDoctorDE

app/lib/actions/settings.dart

@@ -31,15 +31,23 @@ class SettingsAction extends Action<SettingsIntent> {
 Future<void> openSettings(BuildContext context) => showGeneralDialog<void>(
   context: context,
   pageBuilder: (context, animation, secondaryAnimation) => ScaffoldMessenger(
-    child: BackdropFilter(
-      filter: ImageFilter.blur(sigmaX: 5, sigmaY: 5),
-      child: Dialog(
-        clipBehavior: Clip.antiAlias,
-        child: ConstrainedBox(
-          constraints: const BoxConstraints(maxHeight: 800, maxWidth: 1000),
-          child: const SettingsPage(inView: true),
+    child: Stack(
+      alignment: Alignment.center,
+      children: [
+        Positioned.fill(
+          child: BackdropFilter(
+            filter: ImageFilter.blur(sigmaX: 5, sigmaY: 5),
+            child: const SizedBox.expand(),
+          ),
         ),
-      ),
+        Dialog(
+          clipBehavior: Clip.antiAlias,
+          child: ConstrainedBox(
+            constraints: const BoxConstraints(maxHeight: 800, maxWidth: 1000),
+            child: const SettingsPage(inView: true),
+          ),
+        ),
+      ],
     ),
   ),
   barrierDismissible: true,

app/lib/cubits/editor_renderer.dart

@@ -103,6 +103,7 @@ class RendererCubit extends Cubit<RendererRuntimeState> {
   _RendererSpatialIndex? _spatialIndex;
   List<Renderer<PadElement>>? _indexedRenderers;
   Set<Renderer<PadElement>>? _indexedUnbaked;
+  bool _useDirectRendering = false;
 
   void bindController(EditorController controller) {
     _controller = controller;
@@ -455,8 +456,6 @@ class RendererCubit extends Cubit<RendererRuntimeState> {
       size /= resolution.multiplier;
     }
     var transform = transformCubit.state;
-    final recorder = ui.PictureRecorder();
-    final canvas = ui.Canvas(recorder);
     final rect = rendererCubit.getViewportRect(
       transformCubit,
       viewportSize: size,
@@ -529,8 +528,6 @@ class RendererCubit extends Cubit<RendererRuntimeState> {
       targetSize: size,
     );
 
-    canvas.scale(ratio);
-
     if (viewChanged && visibleElements.isNotEmpty) {
       await Future.wait(
         visibleElements.map(
@@ -543,6 +540,43 @@ class RendererCubit extends Cubit<RendererRuntimeState> {
     // Wait one frame
     await Future.delayed(const Duration(milliseconds: 1));
 
+    void useDirectRendering() {
+      if (controller.isClosed ||
+          !identical(rendererCubit.state.cameraViewport, startViewport) ||
+          transformCubit.state != startTransform) {
+        return;
+      }
+      rendererCubit._invalidateSpatialIndex();
+      rendererCubit.setViewport(
+        cameraViewport
+            .unbake(
+              unbakedElements: renderers,
+              visibleElements: visibleElements,
+              visibleUnbakedElements: visibleElements,
+              rendererStates: allRendererStates,
+            )
+            .copyWith(
+              width: size.width,
+              height: size.height,
+              viewportSize: measuredViewportSize,
+              pixelRatio: ratio,
+              resolution: resolution,
+              scale: transform.size,
+              x: renderTransform.position.dx,
+              y: renderTransform.position.dy,
+              invisibleLayers: invisibleLayers,
+            ),
+      );
+    }
+
+    if (_useDirectRendering) {
+      useDirectRendering();
+      return;
+    }
+
+    final recorder = ui.PictureRecorder();
+    final canvas = ui.Canvas(recorder)..scale(ratio);
+
     ViewPainter(
       document,
       page,
@@ -567,6 +601,15 @@ class RendererCubit extends Cubit<RendererRuntimeState> {
     ui.Image newImage;
     try {
       newImage = await picture.toImage(imageWidth, imageHeight);
+    } catch (error, stackTrace) {
+      _useDirectRendering = true;
+      talker.warning(
+        'Viewport image baking failed; using direct rendering',
+        error,
+        stackTrace,
+      );
+      useDirectRendering();
+      return;
     } finally {
       picture.dispose();
     }

metadata/en-US/changelogs/189.txt

@@ -12,6 +12,7 @@
 * Remove unused view options
 * Improve negative scaling
 * Improve rotated elements transformtion ([#1099](https://github.com/LinwoodDev/Butterfly/issues/1099))
+* Improve rendering reliability if baking fails
 * Fix crash with android saf on folders with many files
 * Fix blur resetting on color change
 * Fix polygon collision aabb tests if closed ([#1162](https://github.com/LinwoodDev/Butterfly/pull/1162))