fix: fix memory leak in BinaryStream

refactor: use shared_ptr in ConfIniClass

Author: ShrBox

src/legacy/api/ContainerAPI.h

@@ -8,6 +8,7 @@
 class Container;
 class ContainerClass : public ScriptClass {
 private:
+    // Container is managed by BDS, so use raw pointer
     Container* container;
 
 public:

src/legacy/api/DataAPI.cpp

@@ -9,7 +9,6 @@
 #include "ll/api/utils/StringUtils.h"
 #include "lse/api/Hash.h"
 #include "main/EconomicSystem.h"
-#include "mc/deps/crypto/hash/Hash.h"
 #include "utils/JsonHelper.h"
 
 #include <ctre/ctre.hpp>

src/legacy/api/DataAPI.h

@@ -97,7 +97,7 @@ extern ClassDefine<ConfJsonClass> ConfJsonClassBuilder;
 
 class ConfIniClass : public ScriptClass, public ConfBaseClass {
 private:
-    std::shared_ptr<SimpleIni> iniConf;
+    std::unique_ptr<SimpleIni> iniConf = nullptr;
     bool                       flush() override;
     bool                       close() override;
     bool                       reload() override;

src/legacy/api/DatabaseAPI.h

@@ -8,7 +8,7 @@
 //// KVDB
 class KVDBClass : public ScriptClass {
 private:
-    std::unique_ptr<ll::data::KeyValueDB> kvdb;
+    std::unique_ptr<ll::data::KeyValueDB> kvdb                = nullptr;
     int                                   unloadCallbackIndex = -1;
 
 public:

src/legacy/api/ItemAPI.h

@@ -10,7 +10,8 @@ class ItemStack;
 
 class ItemClass : public ScriptClass {
 private:
-    std::variant<ItemStack*, std::unique_ptr<ItemStack>> item; // BDS manages ItemStack*
+    // ItemStack* is managed by BDS// ItemStack* is managed by BDS
+    std::variant<ItemStack*, std::unique_ptr<ItemStack>> item;
 
     // Pre data
     std::string name, type;

src/legacy/api/NbtAPI.h

@@ -30,7 +30,7 @@ extern ClassDefine<void> NbtStaticBuilder;
 // NBT Byte
 class NbtByteClass : public ScriptClass {
 public:
-    std::unique_ptr<ByteTag> nbt;
+    std::unique_ptr<ByteTag> nbt       = nullptr;
     bool                     canDelete = true;
 
     explicit NbtByteClass(const Local<Object>& scriptObj, std::unique_ptr<ByteTag> p);
@@ -54,7 +54,7 @@ extern ClassDefine<NbtByteClass> NbtByteClassBuilder;
 // NBT Short
 class NbtShortClass : public ScriptClass {
 public:
-    std::unique_ptr<ShortTag> nbt;
+    std::unique_ptr<ShortTag> nbt       = nullptr;
     bool                      canDelete = true;
 
     explicit NbtShortClass(const Local<Object>& scriptObj, std::unique_ptr<ShortTag> p);
@@ -78,7 +78,7 @@ extern ClassDefine<NbtShortClass> NbtShortClassBuilder;
 // NBT Int
 class NbtIntClass : public ScriptClass {
 public:
-    std::unique_ptr<IntTag> nbt;
+    std::unique_ptr<IntTag> nbt       = nullptr;
     bool                    canDelete = true;
 
     explicit NbtIntClass(const Local<Object>& scriptObj, std::unique_ptr<IntTag> p);
@@ -102,7 +102,7 @@ extern ClassDefine<NbtIntClass> NbtIntClassBuilder;
 // NBT Long
 class NbtLongClass : public ScriptClass {
 public:
-    std::unique_ptr<Int64Tag> nbt;
+    std::unique_ptr<Int64Tag> nbt       = nullptr;
     bool                      canDelete = true;
 
     explicit NbtLongClass(const Local<Object>& scriptObj, std::unique_ptr<Int64Tag> p);
@@ -126,7 +126,7 @@ extern ClassDefine<NbtLongClass> NbtLongClassBuilder;
 // NBT Float
 class NbtFloatClass : public ScriptClass {
 public:
-    std::unique_ptr<FloatTag> nbt;
+    std::unique_ptr<FloatTag> nbt       = nullptr;
     bool                      canDelete = true;
 
     explicit NbtFloatClass(const Local<Object>& scriptObj, std::unique_ptr<FloatTag> p);
@@ -150,7 +150,7 @@ extern ClassDefine<NbtFloatClass> NbtFloatClassBuilder;
 // NBT Double
 class NbtDoubleClass : public ScriptClass {
 public:
-    std::unique_ptr<DoubleTag> nbt;
+    std::unique_ptr<DoubleTag> nbt       = nullptr;
     bool                       canDelete = true;
 
     explicit NbtDoubleClass(const Local<Object>& scriptObj, std::unique_ptr<DoubleTag> p);
@@ -174,7 +174,7 @@ extern ClassDefine<NbtDoubleClass> NbtDoubleClassBuilder;
 // NBT String
 class NbtStringClass : public ScriptClass {
 public:
-    std::unique_ptr<StringTag> nbt;
+    std::unique_ptr<StringTag> nbt       = nullptr;
     bool                       canDelete = true;
 
     explicit NbtStringClass(const Local<Object>& scriptObj, std::unique_ptr<StringTag> p);
@@ -198,7 +198,7 @@ extern ClassDefine<NbtStringClass> NbtStringClassBuilder;
 // NBT ByteArray
 class NbtByteArrayClass : public ScriptClass {
 public:
-    std::unique_ptr<ByteArrayTag> nbt;
+    std::unique_ptr<ByteArrayTag> nbt       = nullptr;
     bool                          canDelete = true;
 
     explicit NbtByteArrayClass(const Local<Object>& scriptObj, std::unique_ptr<ByteArrayTag> p);
@@ -222,7 +222,7 @@ extern ClassDefine<NbtByteArrayClass> NbtByteArrayClassBuilder;
 // NBT List
 class NbtListClass : public ScriptClass {
 public:
-    std::unique_ptr<ListTag> nbt;
+    std::unique_ptr<ListTag> nbt       = nullptr;
     bool                     canDelete = true;
 
     explicit NbtListClass(const Local<Object>& scriptObj, std::unique_ptr<ListTag> p);
@@ -264,7 +264,7 @@ extern ClassDefine<NbtListClass> NbtListClassBuilder;
 // NBT Compound
 class NbtCompoundClass : public ScriptClass {
 public:
-    std::unique_ptr<CompoundTag> nbt;
+    std::unique_ptr<CompoundTag> nbt       = nullptr;
     bool                         canDelete = true;
 
     explicit NbtCompoundClass(const Local<Object>& scriptObj, std::unique_ptr<CompoundTag> p);

src/legacy/api/NetworkAPI.h

@@ -42,7 +42,7 @@ extern ClassDefine<void> NetworkClassBuilder;
 
 class WSClientClass : public ScriptClass {
 private:
-    std::shared_ptr<WebSocketClient> ws;
+    std::shared_ptr<WebSocketClient> ws = nullptr;
     std::list<ListenerListType>      listeners[(int)WSClientEvents::EVENT_COUNT];
     void                             addListener(const string& event, Local<Function> func);
 
@@ -102,7 +102,7 @@ class HttpServerClass : public ScriptClass {
 extern ClassDefine<HttpServerClass> HttpServerClassBuilder;
 
 class HttpRequestClass : public ScriptClass {
-    std::shared_ptr<httplib::Request> req;
+    std::shared_ptr<httplib::Request> req = nullptr;
 
 public:
     HttpRequestClass(const Local<Object>& scriptObj, const httplib::Request& req = {});
@@ -125,7 +125,7 @@ class HttpRequestClass : public ScriptClass {
 extern ClassDefine<HttpRequestClass> HttpRequestClassBuilder;
 
 class HttpResponseClass : public ScriptClass {
-    std::shared_ptr<httplib::Response> resp;
+    std::shared_ptr<httplib::Response> resp = nullptr;
 
 public:
     HttpResponseClass(const Local<Object>& scriptObj, const httplib::Response& resp = {});