fix: fix mc.newItem #348

Author: ShrBox

src/legacy/api/CommandAPI.cpp

@@ -95,10 +95,14 @@ Local<Value> convertResult(ParamStorageType const& result, CommandOrigin const&
             -1
         );
     } else if (result.hold(ParamKind::Kind::Item)) {
-        if (auto itemPtr =
-                ll::service::getLevel()->getItemRegistry().getItem(std::get<CommandItem>(result.value()).mId).lock()) {
-            return ItemClass::newItem(std::make_unique<ItemStack>(*itemPtr));
-        }
+        auto item = std::make_unique<ItemStack>();
+        item->reinit(
+            ll::service::getLevel()->getItemRegistry().getNameFromLegacyID(std::get<CommandItem>(result.value()).mId),
+            1,
+            0
+        );
+        return ItemClass::newItem(std::move(item));
+
     } else if (result.hold(ParamKind::Kind::Actor)) {
         auto arr = Array::newArray();
         for (auto i : std::get<CommandSelector<Actor>>(result.value()).results(origin)) {

src/legacy/api/ItemAPI.cpp

@@ -469,10 +469,9 @@ Local<Value> McClass::newItem(const Arguments& args) {
             if (args.size() >= 2 && args[1].isNumber()) {
                 std::string type = args[0].asString().toString();
                 int         cnt  = args[1].asNumber().toInt32();
-
-                if (auto itemPtr = ll::service::getLevel()->getItemRegistry().getItem(HashedString(type)).lock()) {
-                    return ItemClass::newItem(std::make_unique<ItemStack>(*itemPtr));
-                }
+                auto        item = std::make_unique<ItemStack>();
+                item->reinit(type, cnt, 0);
+                return ItemClass::newItem(std::move(item));
             } else {
                 LOG_TOO_FEW_ARGS(__FUNCTION__);
                 return Local<Value>();