fix(runtime): improve VC runtime detection stability

Author: dreamguxiang

frontend/src/hooks/useLauncher.ts

@@ -29,6 +29,7 @@ const DEPENDENCY_CHECK_SESSION_KEYS = {
   gamingServices: "ll.session.dependency-check.gamingservices",
   vcRuntime: "ll.session.dependency-check.vcruntime",
 } as const;
+const VC_RUNTIME_CHECK_RETRY_DELAY_MS = 800;
 
 const hasSessionDependencyCheckRun = (
   key: (typeof DEPENDENCY_CHECK_SESSION_KEYS)[keyof typeof DEPENDENCY_CHECK_SESSION_KEYS],
@@ -616,17 +617,43 @@ export const useLauncher = (args: any) => {
 
   useEffect(() => {
     if (!hasBackend) return;
+    let disposed = false;
+    let vcRuntimeRetryTimer: number | null = null;
+
+    const runVcRuntimeDependencyCheck = (attempt: number) => {
+      const checkVcRuntime = (minecraft as any)?.IsVcRuntimeInstalled;
+      if (typeof checkVcRuntime !== "function") {
+        return;
+      }
+
+      Promise.resolve(checkVcRuntime())
+        .then((ok: boolean) => {
+          if (disposed) return;
+          markSessionDependencyCheckRun(DEPENDENCY_CHECK_SESSION_KEYS.vcRuntime);
+          if (!ok) {
+            vcRuntimeMissingDisclosure.onOpen();
+          }
+        })
+        .catch((error: unknown) => {
+          if (disposed) return;
+          console.warn("Failed to check VC runtime status", error);
+          if (attempt > 0 || vcRuntimeRetryTimer !== null) {
+            return;
+          }
+          vcRuntimeRetryTimer = window.setTimeout(() => {
+            vcRuntimeRetryTimer = null;
+            if (disposed) return;
+            runVcRuntimeDependencyCheck(attempt + 1);
+          }, VC_RUNTIME_CHECK_RETRY_DELAY_MS);
+        });
+    };
+
     const timer = setTimeout(() => {
       if (
         !hasSessionDependencyCheckRun(DEPENDENCY_CHECK_SESSION_KEYS.vcRuntime)
       ) {
-        markSessionDependencyCheckRun(DEPENDENCY_CHECK_SESSION_KEYS.vcRuntime);
         try {
-          (minecraft as any)?.IsVcRuntimeInstalled?.().then((ok: boolean) => {
-            if (!ok) {
-              vcRuntimeMissingDisclosure.onOpen();
-            }
-          });
+          runVcRuntimeDependencyCheck(0);
         } catch {}
       }
       if (
@@ -661,7 +688,14 @@ export const useLauncher = (args: any) => {
         } catch {}
       }
     }, 0);
-    return () => clearTimeout(timer);
+
+    return () => {
+      disposed = true;
+      clearTimeout(timer);
+      if (vcRuntimeRetryTimer !== null) {
+        clearTimeout(vcRuntimeRetryTimer);
+      }
+    };
   }, [
     hasBackend,
     gameInputMissingDisclosure,

internal/vcruntime/vcruntime.go

@@ -41,9 +41,26 @@ type EnsureProgress struct {
 	Total      int64
 }
 
+type vcRuntimeRegistryState struct {
+	Installed    uint64
+	HasInstalled bool
+	Version      string
+	Major        uint64
+	HasMajor     bool
+}
+
 var (
-	mu       sync.Mutex
-	ensuring bool
+	mu                       sync.Mutex
+	ensuring                 bool
+	vcRuntimeMismatchLogOnce sync.Once
+	vcRuntimeRegistryPaths   = []string{
+		`SOFTWARE\Microsoft\VisualStudio\14.0\VC\Runtimes\x64`,
+		`SOFTWARE\Wow6432Node\Microsoft\VisualStudio\14.0\VC\Runtimes\x64`,
+	}
+	vcRuntimeUninstallKeyPaths = []string{
+		`SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall`,
+		`SOFTWARE\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall`,
+	}
 )
 
 //go:embed vcruntime140_1.dll
@@ -64,18 +81,64 @@ func fileSHA256(p string) ([]byte, error) {
 	return h.Sum(nil), nil
 }
 
-func hasVCMinimumRuntime(path string) bool {
+func readVcRuntimeRegistryState(path string) (vcRuntimeRegistryState, bool) {
 	key, err := winreg.OpenKey(winreg.LOCAL_MACHINE, path, winreg.READ)
 	if err != nil {
+		return vcRuntimeRegistryState{}, false
+	}
+	defer key.Close()
+
+	state := vcRuntimeRegistryState{}
+	if installed, _, err := key.GetIntegerValue("Installed"); err == nil {
+		state.Installed = installed
+		state.HasInstalled = true
+	}
+	if version, _, err := key.GetStringValue("Version"); err == nil {
+		state.Version = strings.TrimSpace(version)
+	}
+	if major, _, err := key.GetIntegerValue("Major"); err == nil {
+		state.Major = major
+		state.HasMajor = true
+	}
+	return state, true
+}
+
+func isVcRuntimeRegistryStateInstalled(state vcRuntimeRegistryState) bool {
+	if !state.HasInstalled || state.Installed != 1 {
 		return false
 	}
+	if strings.TrimSpace(state.Version) != "" {
+		return true
+	}
+	return state.HasMajor && state.Major >= 14
+}
+
+func hasInstalledVcRuntime(paths []string, readState func(string) (vcRuntimeRegistryState, bool)) bool {
+	for _, path := range paths {
+		state, ok := readState(path)
+		if !ok {
+			continue
+		}
+		if isVcRuntimeRegistryStateInstalled(state) {
+			return true
+		}
+	}
+	return false
+}
+
+func readVCUninstallDisplayNames(path string) ([]string, error) {
+	key, err := winreg.OpenKey(winreg.LOCAL_MACHINE, path, winreg.READ)
+	if err != nil {
+		return nil, err
+	}
 	defer key.Close()
 
 	names, err := key.ReadSubKeyNames(-1)
 	if err != nil {
-		return false
+		return nil, err
 	}
 
+	displayNames := make([]string, 0, len(names))
 	for _, name := range names {
 		sub, err := winreg.OpenKey(key, name, winreg.QUERY_VALUE)
 		if err != nil {
@@ -86,21 +149,54 @@ func hasVCMinimumRuntime(path string) bool {
 		if err != nil {
 			continue
 		}
+		displayNames = append(displayNames, displayName)
+	}
+	return displayNames, nil
+}
 
+func hasVCUninstallEvidenceFromDisplayNames(displayNames []string) bool {
+	for _, displayName := range displayNames {
 		l := strings.ToLower(strings.TrimSpace(displayName))
-		if strings.Contains(l, "visual c++") &&
-			strings.Contains(l, "x64") &&
-			strings.Contains(l, "2022") &&
-			strings.Contains(l, "minimum runtime") {
+		if !strings.Contains(l, "visual c++") || !strings.Contains(l, "x64") {
+			continue
+		}
+		if !strings.Contains(l, "redistributable") && !strings.Contains(l, "runtime") {
+			continue
+		}
+		if strings.Contains(l, "2015") ||
+			strings.Contains(l, "2017") ||
+			strings.Contains(l, "2019") ||
+			strings.Contains(l, "2022") ||
+			strings.Contains(l, "v14") {
+			return true
+		}
+	}
+	return false
+}
+
+func hasVCUninstallEvidence(readDisplayNames func(string) ([]string, error)) bool {
+	for _, path := range vcRuntimeUninstallKeyPaths {
+		displayNames, err := readDisplayNames(path)
+		if err != nil {
+			continue
+		}
+		if hasVCUninstallEvidenceFromDisplayNames(displayNames) {
 			return true
 		}
 	}
 	return false
 }
 
 func IsInstalled() bool {
-	return hasVCMinimumRuntime(`SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall`) ||
-		hasVCMinimumRuntime(`SOFTWARE\Wow6432Node\Microsoft\Windows\CurrentVersion\Uninstall`)
+	if hasInstalledVcRuntime(vcRuntimeRegistryPaths, readVcRuntimeRegistryState) {
+		return true
+	}
+	if hasVCUninstallEvidence(readVCUninstallDisplayNames) {
+		vcRuntimeMismatchLogOnce.Do(func() {
+			log.Println("vcruntime: found Visual C++ uninstall entries but official VC runtime registry keys are missing")
+		})
+	}
+	return false
 }
 
 func EnsureInteractive(ctx context.Context) {